Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: "fatal error: concurrent map writes" during go get [1.13 backport] #35318

Closed
gopherbot opened this issue Nov 3, 2019 · 4 comments
Closed

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 3, 2019

@bcmills requested issue #35317 to be considered for backport to the next 1.13 minor release.

@gopherbot, please backport to 1.13: this is a regression and a data race.

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Nov 5, 2019

Change https://golang.org/cl/205517 mentions this issue: [release-branch.go1.13] cmd/go/internal/modget: synchronize writes to modOnly map in runGet

@dmitshur

This comment has been minimized.

Copy link
Member

@dmitshur dmitshur commented Nov 26, 2019

Approving because this is a serious problem without an obvious workaround, and the fix is localized.

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Nov 26, 2019

Closed by merging 674a524 to release-branch.go1.13.

@gopherbot gopherbot closed this Nov 26, 2019
gopherbot pushed a commit that referenced this issue Nov 26, 2019
… modOnly map in runGet

Updates #35317
Fixes #35318

Change-Id: Id858a25dc16a1bbff1802d25bcd4aca31c1133bc
Reviewed-on: https://go-review.googlesource.com/c/go/+/205067
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
(cherry picked from commit 7e71c9c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/205517
@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Dec 3, 2019

Change https://golang.org/cl/209222 mentions this issue: [release-branch.go1.13] cmd/go/internal/modget: synchronize writes to modOnly map in runGet

gopherbot pushed a commit that referenced this issue Dec 3, 2019
… modOnly map in runGet

Adds an additional lock around an access to modOnly.

Updates #35317
Fixes #35318

Change-Id: Ia1e75f9a674ec2a2c0489b41283c1cd3e7924d1e
Reviewed-on: https://go-review.googlesource.com/c/go/+/209237
Run-TryBot: Jay Conrod <jayconrod@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
(cherry picked from commit 9174e2c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/209222
Run-TryBot: Alexander Rakoczy <alex@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.