Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: "unknown directive" in TestScript/mod_concurrent #35425

Closed
bcmills opened this issue Nov 7, 2019 · 4 comments
Closed

cmd/go: "unknown directive" in TestScript/mod_concurrent #35425

bcmills opened this issue Nov 7, 2019 · 4 comments
Assignees
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Nov 7, 2019

linux-amd64-nocgo (https://build.golang.org/log/4668306396e340463394550d95aee1d8b4867350):

--- FAIL: TestScript (0.00s)
    --- FAIL: TestScript/mod_concurrent (0.05s)
        script_test.go:192: 
            # Concurrent builds should succeed, even if they need to download modules. (0.043s)
            > go build ./x &
            > go build ./y
            [stderr]
            go: downloading rsc.io/sampler v1.0.0
            > wait
            [background] go build ./x: exit status 1
            [stderr]
            go: errors parsing go.mod:
            $WORK/gopath/src/go.mod:7: unknown directive: v1.0.0
            $WORK/gopath/src/go.mod:8: unknown directive: )
            FAIL: testdata/script/mod_concurrent.txt:6: unexpected command failure
            
FAIL
FAIL	cmd/go	77.618s

I've only seen one of these failures, but this failure mode suggests a possible bug in CL 205637.

CC @jayconrod

@bcmills bcmills added this to the Go1.14 milestone Nov 7, 2019
@bcmills bcmills self-assigned this Nov 7, 2019
@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented Nov 8, 2019

@bcmills

This comment has been minimized.

Copy link
Member Author

@bcmills bcmills commented Nov 8, 2019

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 8, 2019

Change https://golang.org/cl/206142 mentions this issue: cmd/go/internal/modload: use lockedfile.Read for the initial read of the go.mod file

@gopherbot

This comment has been minimized.

Copy link

@gopherbot gopherbot commented Nov 8, 2019

Change https://golang.org/cl/206143 mentions this issue: cmd/go/internal/lockedfile: add a unit-test for Transform

@gopherbot gopherbot closed this in c5fac1e Nov 8, 2019
gopherbot pushed a commit that referenced this issue Nov 8, 2019
Updates #35425

Change-Id: I9ca2251246ee2fa9bb7a335d5eff94d3c9f1f004
Reviewed-on: https://go-review.googlesource.com/c/go/+/206143
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.