x/sys: Commit bc7efcf introduced a compilation error #36032

brotherlogic · 2019-12-07T01:45:23Z

What version of Go are you using (`go version`)?

$ go version
go version go1.12.14 linux/arm

Does this issue reproduce with the latest release?

Not sure

What operating system and processor architecture are you using (`go env`)?

go env Output

$ go env
GOARCH="arm"

GOBIN=""

GOCACHE="/home/simon/.cache/go-build"

GOEXE=""

GOFLAGS=""

GOHOSTARCH="arm"

GOHOSTOS="linux"

GOOS="linux"

GOPATH="/home/simon/code"

GOPROXY=""

GORACE=""

GOROOT="/usr/lib/go"

GOTMPDIR=""

GOTOOLDIR="/usr/lib/go/pkg/tool/linux_arm"

GCCGO="gccgo"

GOARM="6"

CC="gcc"

CXX="g++"

CGO_ENABLED="1"

GOMOD=""

CGO_CFLAGS="-g -O2"

CGO_CPPFLAGS=""

CGO_CXXFLAGS="-g -O2"

CGO_FFLAGS="-g -O2"

CGO_LDFLAGS="-g -O2"

PKG_CONFIG="pkg-config"

GOGCCFLAGS="-fPIC -marm -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build242404953=/tmp/go-build -gno-record-gcc-switches"

What did you do?

go build on any binary

What did you expect to see?

Compilation

What did you see instead?

golang.org/x/sys/unix

/home/simon/code/src/golang.org/x/sys/unix/zptrace_armnn_linux.go:45:57: cannot use uint64(unsafe.Sizeof(*regsout)) (type uint64) as type uint32 in field value
/home/simon/code/src/golang.org/x/sys/unix/zptrace_armnn_linux.go:51:54: cannot use uint64(unsafe.Sizeof(*regs)) (type uint64) as type uint32 in field value

The text was updated successfully, but these errors were encountered:

stgraber · 2019-12-07T01:49:50Z

I was literally writing the exact same report.

root@go-armhf:~# go get golang.org/x/sys/unix
# golang.org/x/sys/unix
go/src/golang.org/x/sys/unix/zptrace_armnn_linux.go:45:57: cannot use uint64(unsafe.Sizeof(*regsout)) (type uint64) as type uint32 in field value
go/src/golang.org/x/sys/unix/zptrace_armnn_linux.go:51:54: cannot use uint64(unsafe.Sizeof(*regs)) (type uint64) as type uint32 in field value
root@go-armhf:~# go version
go version go1.13.5 linux/arm

stgraber · 2019-12-07T01:53:13Z

bc7efcf is the commit modifying zptrace_armnn_linux.go and introducing the issue.

stgraber · 2019-12-07T01:54:11Z

golang/sys@bc7efcf

ianlancetaylor · 2019-12-07T02:33:56Z

I can't think of any approach we can use here other than generating yet another zptrace file.

happyEgg · 2019-12-07T09:47:59Z

I had the same problem, when i execute gomobile build -target=android
go version go1.13.5 darwin/amd64
gomobile is latest
gomobile log:
commit 5c0e7e404af8b014d8b7de89f9522bc92463f3cb (HEAD -> master, origin/master, origin/HEAD)
Author: Hajime Hoshi hajimehoshi@gmail.com
Date: Wed Nov 27 22:57:30 2019 +0900

probonopd · 2019-12-07T16:18:54Z

Also running into this error. Getting this lately:

env CC=arm-linux-gnueabi-gcc CGO_ENABLED=1 GOOS=linux GOARCH=arm GOARM=5 go build -trimpath -ldflags="-s -w -X main.commit=$COMMIT" github.com/probonopd/go-appimage/src/appimaged

# golang.org/x/sys/unix

../../../go/src/golang.org/x/sys/unix/zptrace_armnn_linux.go:45:57: cannot use uint64(unsafe.Sizeof(*regsout)) (type uint64) as type uint32 in field value

../../../go/src/golang.org/x/sys/unix/zptrace_armnn_linux.go:51:54: cannot use uint64(unsafe.Sizeof(*regs)) (type uint64) as type uint32 in field value

https://travis-ci.com/probonopd/go-appimage/jobs/264315306#L297-L300

It the bug related to this change?
https://go-review.googlesource.com/c/sys/+/204418

MarcelEeken · 2019-12-07T17:30:35Z

Also just ran into this issue

What version of Go are you using (`go version`)?

$ go version
go version go1.13.5 darwin/amd64

What operating system and processor architecture are you using (`go env`)?

go env Output

$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/marcel/Library/Caches/go-build"
GOENV="/Users/marcel/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/marcel/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/marcel/prive/enmon/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/0s/tlwngfxs4l76lnlk8j3z0s2h0000gn/T/go-build442831853=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Trying to cross compile for ARM target

$ GOOS=linux GOARCH=arm GOARM=6 go build -o build/enmon_arm
# golang.org/x/sys/unix
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20191206220618-eeba5f6aabab/unix/zptrace_armnn_linux.go:45:57: cannot use uint64(unsafe.Sizeof(*regsout)) (type uint64) as type uint32 in field value
../../go/pkg/mod/golang.org/x/sys@v0.0.0-20191206220618-eeba5f6aabab/unix/zptrace_armnn_linux.go:51:54: cannot use uint64(unsafe.Sizeof(*regs)) (type uint64) as type uint32 in field value

ianlancetaylor · 2019-12-07T19:06:18Z

No need to keep reporting the problem. https://golang.org/wiki/NoPlusOne. Thanks.

We know there is a problem and we will either roll back the change or add a fix.

erifan · 2019-12-09T01:20:00Z

Sorry for the trouble. I'll fix it as soon as possible.

bus710 · 2019-12-09T04:54:01Z

A band-aid for beginners like me, pick an older version in the go.mod like this:

golang.org/x/sys v0.0.0-20191126131656-8a8471f7e56d // indirect

erifan · 2019-12-09T05:58:22Z

I have sent out a fix (https://go-review.googlesource.com/c/sys/+/210322) but the page did not refresh.

zikaeroh · 2019-12-09T06:00:21Z

You have to write Fixes golang/go#36032, not Fixes #36032 to get gopherbot to recognize the issue when working from a repo other than the main Go repo.

gopherbot · 2019-12-09T06:07:08Z

Change https://golang.org/cl/210322 mentions this issue: unix: move functions Ptrace{Get|Set}RegSetArm64 to a separate file

erifan · 2019-12-09T06:08:20Z

@zikaeroh Thanks.

zhangfannie · 2019-12-09T11:14:55Z

@ianlancetaylor What about redefining Iovec{} struct as IovecArm64{] struct in unix/zptrace_armnn_linux.go file?

sigkill · 2019-12-09T17:37:59Z

Also breaking P4wnP1_aloa too...

probonopd · 2019-12-09T18:06:47Z

A band-aid for beginners like me, pick an older version in the go.mod like this:

What if one doesn't use modules?

bus710 · 2019-12-09T18:41:48Z

A band-aid for beginners like me, pick an older version in the go.mod like this:

What if one doesn't use modules?

Not sure how many of package managers out there but for Go Dep at least:

https://github.com/golang/dep/blob/master/docs/Gopkg.toml.md
Edit gopkg.toml for the version entry to pick the right branch and commit.

**What** - Pin the version of golang/x/sys It introduced a bug in arm builds, see golang/go#36032. This is needed by docker. Per this ory/dockertest#208 (comment) we can pin golang/x/sys to f9321e4c35a6 for a proper build Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>

gopherbot added this to the Unreleased milestone Dec 7, 2019

ianlancetaylor added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 7, 2019

probonopd mentioned this issue Dec 7, 2019

Compilation error for ARM probonopd/go-appimage#20

Closed

brotherlogic changed the title ~~x/sys: Commit eeba5f6 introduced a compilation error~~ x/sys: Commit bc7efcf introduced a compilation error Dec 7, 2019

cluckj mentioned this issue Dec 8, 2019

Compile error in oref0-setup.sh when choosing to compile go code from source (reoccurence) openaps/oref0#1334

Open

erifan self-assigned this Dec 9, 2019

gopherbot closed this as completed in golang/sys@ac6580d Dec 10, 2019

Martin555 mentioned this issue May 26, 2020

Compilation error with ARM processor (reoccurance) #39263

Closed

LucasRoesler mentioned this issue Sep 17, 2020

Pin the version of golang/x/sys openfaas/faas-cli#826

Merged

11 tasks

golang locked and limited conversation to collaborators Dec 9, 2020

gopherbot added the FrozenDueToAge label Dec 9, 2020

rsc unassigned erifan Jun 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/sys: Commit bc7efcf introduced a compilation error #36032

x/sys: Commit bc7efcf introduced a compilation error #36032

brotherlogic commented Dec 7, 2019

stgraber commented Dec 7, 2019

stgraber commented Dec 7, 2019

stgraber commented Dec 7, 2019

ianlancetaylor commented Dec 7, 2019

happyEgg commented Dec 7, 2019 •

edited

Loading

probonopd commented Dec 7, 2019 •

edited

Loading

MarcelEeken commented Dec 7, 2019

ianlancetaylor commented Dec 7, 2019

erifan commented Dec 9, 2019

bus710 commented Dec 9, 2019

erifan commented Dec 9, 2019

zikaeroh commented Dec 9, 2019 •

edited

Loading

gopherbot commented Dec 9, 2019

erifan commented Dec 9, 2019

zhangfannie commented Dec 9, 2019

sigkill commented Dec 9, 2019

probonopd commented Dec 9, 2019

bus710 commented Dec 9, 2019 •

edited

Loading

x/sys: Commit bc7efcf introduced a compilation error #36032

x/sys: Commit bc7efcf introduced a compilation error #36032

Comments

brotherlogic commented Dec 7, 2019

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

golang.org/x/sys/unix

stgraber commented Dec 7, 2019

stgraber commented Dec 7, 2019

stgraber commented Dec 7, 2019

ianlancetaylor commented Dec 7, 2019

happyEgg commented Dec 7, 2019 • edited Loading

probonopd commented Dec 7, 2019 • edited Loading

MarcelEeken commented Dec 7, 2019

What version of Go are you using (go version)?

What operating system and processor architecture are you using (go env)?

What did you do?

ianlancetaylor commented Dec 7, 2019

erifan commented Dec 9, 2019

bus710 commented Dec 9, 2019

erifan commented Dec 9, 2019

zikaeroh commented Dec 9, 2019 • edited Loading

gopherbot commented Dec 9, 2019

erifan commented Dec 9, 2019

zhangfannie commented Dec 9, 2019

sigkill commented Dec 9, 2019

probonopd commented Dec 9, 2019

bus710 commented Dec 9, 2019 • edited Loading

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

happyEgg commented Dec 7, 2019 •

edited

Loading

probonopd commented Dec 7, 2019 •

edited

Loading

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?

zikaeroh commented Dec 9, 2019 •

edited

Loading

bus710 commented Dec 9, 2019 •

edited

Loading