Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: racy Timer access should either work or throw, not panic [1.14 backport] #37494

Closed
gopherbot opened this issue Feb 27, 2020 · 3 comments
Closed

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Feb 27, 2020

@ianlancetaylor requested issue #37400 to be considered for backport to the next 1.14 minor release.

@gopherbot Please open a backport to 1.14.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Feb 27, 2020

Change https://golang.org/cl/221298 mentions this issue: [release-branch.go1.14] runtime: don't panic on racy use of timers

@dmitshur
Copy link
Member

@dmitshur dmitshur commented Feb 27, 2020

Approving because it is a serious issue without a workaround.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Feb 27, 2020

Closed by merging 3293174 to release-branch.go1.14.

@gopherbot gopherbot closed this Feb 27, 2020
gopherbot pushed a commit that referenced this issue Feb 27, 2020
If we see a racy use of timers, as in concurrent calls to Timer.Reset,
do the operations in an unpredictable order, rather than crashing.

Updates #37400
Updates #37449
Fixes #37494

Change-Id: Idbac295df2dfd551b6d762909d5040fc532c1b34
Reviewed-on: https://go-review.googlesource.com/c/go/+/221077
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
(cherry picked from commit 98858c4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/221298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.