Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: flag packages that are no longer present in the latest version of the containing module #37631

Closed
bcmills opened this issue Mar 3, 2020 · 4 comments

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Mar 3, 2020

What is the URL of the page with the issue?

https://pkg.go.dev/golang.org/x/tools/cmd/vet?tab=doc

What is your user agent?

Mozilla/5.0 (X11; CrOS x86_64 12607.82.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.123 Safari/537.36 

Screenshot

cmd-vet
old-tools

What did you do?

Directly open the doc page for package golang.org/x/tools/cmd/vet.

What did you expect to see?

A prominent warning that the package in question no longer exists, ideally with similar style/coloration to the (currently-red) “Go to latest” link on the module overview page.

What did you see instead?

A normal documentation page for a very old version of golang.org/x/tools/cmd/vet, which was removed from the repo back in 2016, along with a cheerful blue “Latest” badge.

@gopherbot gopherbot added this to the Unreleased milestone Mar 3, 2020
@gopherbot gopherbot added the pkgsite label Mar 3, 2020
@bcmills bcmills added the UX label Mar 3, 2020
@bcmills
Copy link
Member Author

@bcmills bcmills commented Mar 3, 2020

@jba jba self-assigned this Mar 3, 2020
@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Mar 3, 2020

Thanks for the feedback! We plan to fix this as part of an upcoming round of UX changes.

/cc @fflewddur

@julieqiu julieqiu changed the title go.dev: flag packages that are no longer present in the latest version of the containing module x/pkgsite: flag packages that are no longer present in the latest version of the containing module Jun 15, 2020
@gopherbot gopherbot added the go.dev label Sep 18, 2020
@julieqiu julieqiu removed the go.dev label Sep 22, 2020
@gopherbot gopherbot added the go.dev label Sep 22, 2020
@julieqiu julieqiu removed the go.dev label Sep 22, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Dec 22, 2020

Change https://golang.org/cl/279460 mentions this issue: internal/postgres: add GetLatestMinorModuleVersion

gopherbot pushed a commit to golang/pkgsite that referenced this issue Dec 22, 2020
Add a method that returns the latest minor version of a module,
and whether a unit exists in that version.

For golang/go#37631

Change-Id: I3f612b5df561c39831494388bb37bc6ee9096168
Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/279460
Trust: Jonathan Amsterdam <jba@google.com>
Run-TryBot: Jonathan Amsterdam <jba@google.com>
Reviewed-by: Julie Qiu <julie@golang.org>
@jba
Copy link
Contributor

@jba jba commented Jan 15, 2021

We now show an icon on the Latest badge:

image

Clicking on the icon brings up the tooltip "This package is not in the latest version of its module."

@jba jba closed this Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants