Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile/internal/syntax: TestStdLib verbosely broken on Windows [1.13 backport] #37901

Closed
gopherbot opened this issue Mar 17, 2020 · 2 comments
Closed

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 17, 2020

@dmitshur requested issue #35175 to be considered for backport to the next 1.13 minor release.

@gopherbot, please consider this issue for backport to Go 1.13. This is a test fix. It is needed to resolve a test failure in the cmd/compile/internal/syntax package on windows-amd64-longtest builder, which could be masking other problems (due to #36181) and making releasing Go 1.13.x more difficult.

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Mar 17, 2020

Change https://golang.org/cl/223703 mentions this issue: [release-branch.go1.13] cmd/compile/internal/syntax: don't hardwire path separator in test

@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Mar 31, 2020

Closed by merging 5a31a97 to release-branch.go1.13.

@gopherbot gopherbot closed this Mar 31, 2020
gopherbot pushed a commit that referenced this issue Mar 31, 2020
…ath separator in test

Windows uses '\' not '/'.

For #35175.
Fixes #37901.

Change-Id: Ib3d01dcf148fc0675496d5213f5bcc9cf210a6fc
Reviewed-on: https://go-review.googlesource.com/c/go/+/203889
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit a754d29)
Reviewed-on: https://go-review.googlesource.com/c/go/+/223703
Reviewed-by: Robert Griesemer <gri@golang.org>
Run-TryBot: Andrew Bonventre <andybons@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.