Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestDialParallel is flaky on windows-amd64-longtest [1.13 backport] #39538

Closed
gopherbot opened this issue Jun 11, 2020 · 3 comments
Closed

net: TestDialParallel is flaky on windows-amd64-longtest [1.13 backport] #39538

gopherbot opened this issue Jun 11, 2020 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.13.14

Comments

@gopherbot
Copy link

@dmitshur requested issue #35616 to be considered for backport to the next 1.13 minor release.

@gopherbot Please consider for backport to 1.13. This is merely a test fix for a flaky test. It's needed to help #29252.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 11, 2020
@gopherbot gopherbot mentioned this issue Jun 11, 2020
Closed
@gopherbot gopherbot added this to the Go1.13.13 milestone Jun 11, 2020
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jun 11, 2020
@gopherbot
Copy link
Author

Change https://golang.org/cl/237602 mentions this issue: [release-branch.go1.13] net: add more timing slop for TestDialParallel on Windows

@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Jun 12, 2020
@toothrot
Copy link
Contributor

Approving for backport. Stable automated tests are critical to releases.

@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 12, 2020
@gopherbot
Copy link
Author

Closed by merging 7e87a63 to release-branch.go1.13.

gopherbot pushed a commit that referenced this issue Jun 12, 2020
@ianlancetaylor @dmitshur
[release-branch.go1.13] net: add more timing slop for TestDialParalle…
7e87a63 
…l on Windows

For #35616.
Fixes #39538.
For #29252.

Change-Id: I51b2490100cfe0e902da09eee8d027e0ec86ed53
Reviewed-on: https://go-review.googlesource.com/c/go/+/207466
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit c20b71e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/237602
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@andybons andybons modified the milestones: Go1.13.13, Go1.13.14 Jul 14, 2020
@golang golang locked and limited conversation to collaborators Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.13.14
Development

No branches or pull requests
4 participants
@toothrot @andybons @dmitshur @gopherbot