Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestDialParallel is flaky on windows-amd64-longtest [1.13 backport] #39538

Closed
gopherbot opened this issue Jun 11, 2020 · 3 comments
Closed

net: TestDialParallel is flaky on windows-amd64-longtest [1.13 backport] #39538

gopherbot opened this issue Jun 11, 2020 · 3 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Jun 11, 2020

@dmitshur requested issue #35616 to be considered for backport to the next 1.13 minor release.

@gopherbot Please consider for backport to 1.13. This is merely a test fix for a flaky test. It's needed to help #29252.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Jun 11, 2020

Change https://golang.org/cl/237602 mentions this issue: [release-branch.go1.13] net: add more timing slop for TestDialParallel on Windows

@toothrot
Copy link
Contributor

@toothrot toothrot commented Jun 12, 2020

Approving for backport. Stable automated tests are critical to releases.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Jun 12, 2020

Closed by merging 7e87a63 to release-branch.go1.13.

@gopherbot gopherbot closed this Jun 12, 2020
gopherbot pushed a commit that referenced this issue Jun 12, 2020
…l on Windows

For #35616.
Fixes #39538.
For #29252.

Change-Id: I51b2490100cfe0e902da09eee8d027e0ec86ed53
Reviewed-on: https://go-review.googlesource.com/c/go/+/207466
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit c20b71e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/237602
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@andybons andybons modified the milestones: Go1.13.13, Go1.13.14 Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.