Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: check the Key Usage extension #40100

Open
FiloSottile opened this issue Jul 7, 2020 · 2 comments
Open

crypto/x509: check the Key Usage extension #40100

FiloSottile opened this issue Jul 7, 2020 · 2 comments
Labels
Milestone

Comments

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented Jul 7, 2020

We currently ignore the Key Usage extension because some old roots had gotten it wrong. Things probably improved by now and we can take a stab at following the spec again. AFAIK other verifiers do check them.

@FiloSottile FiloSottile added the NeedsFix label Jul 7, 2020
@FiloSottile FiloSottile added this to the Go1.16 milestone Jul 7, 2020
@gopherbot
Copy link

@gopherbot gopherbot commented Aug 5, 2020

Change https://golang.org/cl/246877 mentions this issue: crypto: check the Key Usage extension

@SparrowLii
Copy link

@SparrowLii SparrowLii commented Aug 5, 2020

I searched the crypto pkg and found there are two functions in crypto which relate to KU extension checking:
CheckSignature(x509.go 823) and verifyHandshakeSignature(auth.go 22). But it seems hard to check the KU inside the func body. I think maybe we can check KU before use one PublicKey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.