-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/types: failure to report errors on test/fixedbugs/issue20232.go #42695
Labels
Milestone
Comments
There's at the very least a missing test in operand.setConst: if x.val.Kind() == constant.Unknown {
x.mode = invalid
} |
The 2nd example is already reported as #20583. |
Change https://golang.org/cl/271377 mentions this issue: |
Change https://golang.org/cl/271520 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Nov 19, 2020
…alid constant values This is https://golang.org/cl/271377 ported to types2. Updates #42695. Change-Id: I475bdcaeace5b0e87d4476a6d660996534289666 Reviewed-on: https://go-review.googlesource.com/c/go/+/271520 Trust: Robert Griesemer <gri@golang.org> Run-TryBot: Robert Griesemer <gri@golang.org> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
While integrating go/constant into cmd/compile, I discovered that go/types isn't actually handling the test case from #20232 correctly. In particular, this variation on the test case demonstrates two latent issues:
/cc @griesemer
The text was updated successfully, but these errors were encountered: