Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: GPL3 considered a "permissive license" #43758

Closed
nickjwhite opened this issue Jan 18, 2021 · 8 comments
Closed

x/pkgsite: GPL3 considered a "permissive license" #43758

nickjwhite opened this issue Jan 18, 2021 · 8 comments

Comments

@nickjwhite
Copy link

@nickjwhite nickjwhite commented Jan 18, 2021

I have several packages licensed under GPLv3, which is correctly detected by pkg.go.dev. However I noticed today that in the "details" bar on the right one of the features described is "permissive license". Normally that's a term used for non-copyleft licenses like ISC. An example page where this is the case would be this: https://pkg.go.dev/rescribe.xyz/preproc

In https://pkg.go.dev/about#best-practices-h2 it states that "For more information on how pkg.go.dev determines if a license is permissive, see our license policy", linking to https://pkg.go.dev/license-policy, but that only seems to detail how licenses are detected (which is done correctly in this case), not how "permissive license" is determined.

I think copyleft licensed projects should not be tagged with "permissive license", and ideally tagged "copyleft license" instead, in the details box.

@gopherbot gopherbot added the pkgsite label Jan 18, 2021
@gopherbot gopherbot added this to the Unreleased milestone Jan 18, 2021
@ALTree
Copy link
Member

@ALTree ALTree commented Jan 18, 2021

@FiloSottile
Copy link
Member

@FiloSottile FiloSottile commented Jan 19, 2021

A better term to describe what the pkgsite cares about might be "redistributable license".

@julieqiu
Copy link
Contributor

@julieqiu julieqiu commented Jan 19, 2021

/cc @jba

@julieqiu julieqiu modified the milestones: Unreleased, pkgsite/licenses Jan 19, 2021
@jba
Copy link
Contributor

@jba jba commented Jan 19, 2021

"Redistributable" is the word we use internally, but we worried that it might sound too legalistic. But I suppose that is the right term, so we should use it.

@mvdan
Copy link
Member

@mvdan mvdan commented Jan 19, 2021

For the sake of keeping the language simple, how about "Can be distributed" or "Can be distributed freely"? Or "Allows distribution".

@sudo-sturbia
Copy link

@sudo-sturbia sudo-sturbia commented Jan 19, 2021

@jba This should be closed as it wasn't done automatically by golang/pkgsite@5b39ce4 due to a small misspelling.

@jba
Copy link
Contributor

@jba jba commented Jan 20, 2021

We went with "redistributable." We can always change later.

@jba jba closed this Jan 20, 2021
@nickjwhite
Copy link
Author

@nickjwhite nickjwhite commented Jan 20, 2021

Great, thanks all. I think "redistributable" is clear enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants