Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Broken image in readme [1.16 backport] #44402

Closed
gopherbot opened this issue Feb 19, 2021 · 3 comments
Closed

doc: Broken image in readme [1.16 backport] #44402

gopherbot opened this issue Feb 19, 2021 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases Documentation FrozenDueToAge
Milestone
Go1.16.2

Comments

@gopherbot
Copy link

gopherbot commented Feb 19, 2021 •
edited by dmitshur

@dmitshur requested issue #44295 (fixed in 6f3da9d for Go 1.17) to be considered for backport to the next 1.16 minor release.

@gopherbot Please backport this to Go 1.16. It is a safe documentation fix needed to restore the gopher image at https://pkg.go.dev/std#section-readme (and any other place that displays the README of the Go standard library at release tags).
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 19, 2021
@gopherbot gopherbot mentioned this issue Feb 19, 2021
Closed
@gopherbot
Copy link
Author

Change https://golang.org/cl/293843 mentions this issue: [release-branch.go1.16] README: pull gopher image from website

@gopherbot gopherbot added this to the Go1.16.1 milestone Feb 19, 2021
@cagedmantis
Copy link
Contributor

cagedmantis commented Feb 25, 2021 •
edited

Approved. This is a documentation issue which increases clarity.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Feb 25, 2021
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 25, 2021
@gopherbot
Copy link
Author

Closed by merging 0b8c416 to release-branch.go1.16.

gopherbot pushed a commit that referenced this issue Feb 25, 2021
@ianlancetaylor @dmitshur
[release-branch.go1.16] README: pull gopher image from website
0b8c416 
Fixes breakage accidentally introduced by https://golang.org/cl/291711.

Fixes #44402.
Updates #44295.

Change-Id: I76f3e5577d1d24027d4ed2a725b5b749ab2d059c
Reviewed-on: https://go-review.googlesource.com/c/go/+/292629
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
(cherry picked from commit 6f3da9d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/293843
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
@toothrot toothrot modified the milestones: Go1.16.1, Go1.16.2 Mar 10, 2021
@golang golang locked and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases Documentation FrozenDueToAge
Projects
None yet
Milestone
Go1.16.2
Development

No branches or pull requests
3 participants
@toothrot @cagedmantis @gopherbot