Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/guru: TestGuru consistently failing since CL 295271 #44596

Closed
bcmills opened this issue Feb 25, 2021 · 1 comment
Closed

x/tools/cmd/guru: TestGuru consistently failing since CL 295271 #44596

bcmills opened this issue Feb 25, 2021 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 25, 2021

https://build.golang.org/log/da6da4438e6dd13146dc1090c989f30fc0edf2a1:

testdata/src/softerrs/main.go:8:6: i declared but not used
--- FAIL: TestGuru (0.00s)
    --- FAIL: TestGuru/describe (2.57s)
        guru_test.go:307: Guru tests for testdata/src/describe/main.go failed: exit status 1.
            --- testdata/src/describe/main.golden	2021-02-22 15:35:19.000000000 +0000
            +++ /workdir/tmp/main.got550239221	2021-02-23 04:46:18.741397903 +0000
            @@ -24,7 +24,7 @@
             import of package "unsafe"
             	builtin Alignof 
             	builtin Offsetof
            -	type  Pointer  unsafe.Pointer
            +	type  Pointer  Pointer
             	builtin Sizeof  
             
             -------- @describe type-ref-builtin --------
            
FAIL
FAIL	golang.org/x/tools/cmd/guru	87.042s

From looking at https://build.golang.org/?repo=golang.org%2fx%2ftools, the failure appears to have started at CL 295271 (#44515) in the main repo (@findleyr, @griesemer).

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Feb 25, 2021
@bcmills bcmills added this to the Go1.17 milestone Feb 25, 2021
@griesemer griesemer self-assigned this Feb 25, 2021
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Feb 25, 2021
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/296289 mentions this issue: cmd/guru: update golden file (fix test failure)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants