Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cmd/guru: adjust describe qualifier function (fix describe test)
The go/types fix for golang/go#44515 changed the type string for unsafe.Pointer from a fixed "unsafe.Pointer" to a customizable package path followed by "Pointer" (the customization was in place for any other object already). The package path customization is done through a user-provider types.Qualifier function. If none is provided, the ordinary package path is used ("unsafe"). Guru provides a package-relative qualifier which leaves away the package path if an object is local to a package. As a result, unsafe.Pointer is printed as "Pointer" which breaks an existing test. Provide no qualifier function when printing a type from package unsafe instead (there's only unsafe.Pointer). Since no qualifier was used in the past, this Guru-specific change will also work when run using earlier Go versions. Fixes golang/go#44596. Updates golang/go#44515. Change-Id: I3c467e4ed09aa13deb50368fe98e42c723a6376b Reviewed-on: https://go-review.googlesource.com/c/tools/+/296289 Trust: Robert Griesemer <gri@golang.org> Run-TryBot: Robert Griesemer <gri@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
- Loading branch information