testing/fstest: cannot chmod "." in MapFS

[josharian]

fstest.MapFS synthesizes directories as needed. These directories have mode fs.ModeDir ("d---------"). This is an unhelpful default, in that copying that mode anywhere results in an unreadable directory.

You can work around this by explicitly providing directory entries. This works for all directories except ".". Providing a directory entry for "." causes fs.WalkDir to recurse infinitely.

To reproduce, use https://play.golang.org/p/vVjpRABoLax. Change m["c"] = to m["."] = and hit "run". (To see it working as correctly, replace m["c"] with m["a"].)

The primary issue here is that providing a "." entry for fstest.MapFS should generate a well-formed filesystem. Secondarily, we might also want to change the default mode of synthesized fstest.MapFS directories and/or prevent infinite recursion in fs.WalkDir using a cheap cycle detection algorithm like Floyd-Warshall. (Opinions about these secondary fixes?)

The playground code mentioned above:

package main

import (
	"fmt"
	"io/fs"
	"testing/fstest"
)

func main() {

	m := make(fstest.MapFS)
	m["a/b.txt"] = &fstest.MapFile{
		Mode: 0666,
	}
	m["c"] = &fstest.MapFile{
		Mode: 0777 | fs.ModeDir,
	}
	fs.WalkDir(m, ".", func(path string, d fs.DirEntry, err error) error {
		fi, err := d.Info()
		if err != nil {
			return err
		}
		fmt.Printf("%s: %v\n", path, fi.Mode())
		return nil
	})
}

cc @rsc @ianlancetaylor

[gopherbot]

Change https://golang.org/cl/328409 mentions this issue: testing/fstest: allow specifying file for "." in MapFS