You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've manually reviewed all uses of ctxt.Flag_shared and they all look concurrency-safe to me. And I manually tested with the race detector and found no issues. I'm going to send a CL removing that particular check.
Maybe. For what its worth: recompiling gotip with this CL applied does not provide a speedup afaikt:
❯ time GOROOT_BOOTSTRAP=/Users/andig/htdocs/golang ./make.bash
Building Go cmd/dist using /Users/andig/htdocs/golang. (devel go1.18-579ff8b131 Mon Oct 4 19:51:37 2021 +0000 darwin/arm64)
Building Go toolchain1 using /Users/andig/htdocs/golang.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for darwin/arm64.
Installed Go for darwin/arm64 in /Users/andig/htdocs/golang2
Installed commands in /Users/andig/htdocs/golang2/bin
GOROOT_BOOTSTRAP=/Users/andig/htdocs/golang ./make.bash 166.35s user 19.85s system 421% cpu 44.204 total
I've manually reviewed all uses of ctxt.Flag_shared for concurrency safety.
And I manually tested with the race detector and found no issues.
Allow -shared to be used with compiler concurrency,
thereby re-enabling concurrent compilation on darwin/arm64.
Trust: Josh Bleecher Snyder <email@example.com>
Reviewed-by: Bryan C. Mills <firstname.lastname@example.org>
(cherry picked from commit 579ff8b)