Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gomote: add gomote session manager package #48735

Open
2 tasks
cagedmantis opened this issue Oct 1, 2021 · 2 comments
Open
2 tasks

x/build/cmd/gomote: add gomote session manager package #48735

cagedmantis opened this issue Oct 1, 2021 · 2 comments

Comments

@cagedmantis
Copy link
Contributor

@cagedmantis cagedmantis commented Oct 1, 2021

Add a component which manages gomote instances. This component should:

  • Manage the lifecycle of SSH certificates (creates, destroys, read requests )
  • Manage the lifecycle of gomote sessions (handle timeouts)

This is a component of the project to revamp the security model used by gomote #47521
@golang/release

@cagedmantis cagedmantis added this to the Backlog milestone Oct 1, 2021
@cagedmantis cagedmantis added this to Planned in Go Release Team Oct 5, 2021
@cagedmantis cagedmantis changed the title x/build/cmd/gomote: add gomote manager component x/build/cmd/gomote: add gomote session manager package Nov 2, 2021
@gopherbot
Copy link

@gopherbot gopherbot commented Nov 3, 2021

Change https://golang.org/cl/361097 mentions this issue: internal/coordinator/remote: refactor remote buildlet session

Loading

@gopherbot
Copy link

@gopherbot gopherbot commented Nov 3, 2021

Change https://golang.org/cl/361096 mentions this issue: internal/coordinator/remote: copy existing remote buildlet management

Loading

gopherbot pushed a commit to golang/build that referenced this issue Nov 8, 2021
This change copies the remote buildlet session management logic from
the cmd/coordinator/remote.go file. This copies the existing
implementation without including the HTTP and SSH handlers which also
contain small portions of logic. This is the first step before
refactoring the implementation which will be used in the GRPC server.

Updates golang/go#48735

Change-Id: Idb26616ddb5494a8f96f8b66369e20f19f2871dc
Reviewed-on: https://go-review.googlesource.com/c/build/+/361096
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Nov 22, 2021
This change refactors the existing remote buildlet session management
implementation. It implements logic which was originally found in the
HTTP handlers and moves it into a session manager. This change also
introduces a fake buildlet client intended to be used for testing when
additional functionality is added to the session pool.

Updates golang/go#48735

Change-Id: Ib7d66cefb9847cf2659e7049f707d78536fbbbea
Reviewed-on: https://go-review.googlesource.com/c/build/+/361097
Trust: Carlos Amedee <carlos@golang.org>
Run-TryBot: Carlos Amedee <carlos@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@cagedmantis cagedmantis moved this from Planned to In Progress in Go Release Team Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Go Release Team
In Progress
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants