Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: frequent test failures with "context deadline exceeded" on linux-riscv64-unmatched builder #49321

Open
bcmills opened this issue Nov 3, 2021 · 5 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@bcmills
Copy link
Member

bcmills commented Nov 3, 2021

greplogs --dashboard -md -l -e '(?ms)\Alinux-riscv.*context deadline exceeded.*FAIL\s+golang\.org/x/tools/gopls'

2021-11-03T09:23:34-714668c-6458b2e/linux-riscv64-unmatched
2021-11-03T00:49:50-714668c-a4b2c57/linux-riscv64-unmatched
2021-11-01T19:56:50-ee08195-5f1bcd1/linux-riscv64-unmatched
2021-11-01T02:47:30-351c04c-fde4cc2/linux-riscv64-unmatched
2021-10-31T18:39:05-351c04c-89c5270/linux-riscv64-unmatched
2021-10-31T08:29:02-351c04c-8e3d5f0/linux-riscv64-unmatched
2021-10-31T02:24:29-351c04c-0bef30d/linux-riscv64-unmatched
2021-10-30T18:30:34-351c04c-6113dac/linux-riscv64-unmatched
2021-10-29T22:29:31-a2be0cd-c812b97/linux-riscv64-unmatched
2021-10-29T04:21:07-d6a9af8-f288526/linux-riscv64-unmatched
2021-10-28T22:38:00-e7eb6f6-af05d8b/linux-riscv64-unmatched
2021-10-26T05:05:24-903c757-23fdd7f/linux-riscv64-unmatched
2021-10-23T12:53:38-affba50-b0f7eb6/linux-riscv64-unmatched
2021-10-22T21:48:34-316ba0b-ae4d67c/linux-riscv64-unmatched
2021-10-21T02:35:47-9b675d0-fca46d0/linux-riscv64-unmatched
2021-10-20T20:58:15-9b675d0-73652af/linux-riscv64-unmatched
2021-10-20T15:03:54-4ea6123-27a1454/linux-riscv64-unmatched
2021-10-20T07:49:28-4ea6123-d2ec73c/linux-riscv64-unmatched
2021-10-19T23:27:41-4ea6123-2be5b84/linux-riscv64-unmatched
2021-10-19T20:35:15-1feb683-07e5527/linux-riscv64-unmatched
2021-10-17T04:27:13-98f6e03-cf51fb5/linux-riscv64-unmatched
2021-10-17T02:23:16-98f6e03-fa7d11a/linux-riscv64-unmatched
2021-10-16T16:27:40-98f6e03-640a49b/linux-riscv64-unmatched
2021-10-16T14:50:21-98f6e03-680caf1/linux-riscv64-unmatched
2021-10-15T18:07:49-98f6e03-8331f25/linux-riscv64-unmatched
2021-10-15T16:00:01-98f6e03-fad4a16/linux-riscv64-unmatched
2021-10-15T07:13:43-288d0b3-1cbec68/linux-riscv64-unmatched
2021-10-15T05:20:52-288d0b3-81484cf/linux-riscv64-unmatched
2021-10-15T03:49:17-288d0b3-8dab959/linux-riscv64-unmatched
2021-10-15T00:16:20-ce04ca3-9e8ed86/linux-riscv64-unmatched
2021-10-14T23:32:09-3a269dc-9e8ed86/linux-riscv64-unmatched
2021-10-14T21:08:41-e69ba9d-0400d53/linux-riscv64-unmatched
2021-10-14T19:24:35-e69ba9d-4cbc0a5/linux-riscv64-unmatched
2021-10-14T14:04:14-e69ba9d-24e798e/linux-riscv64-unmatched
2021-10-14T04:18:44-acac939-9e4dc6f/linux-riscv64-unmatched
2021-10-14T00:44:41-acac939-b90d258/linux-riscv64-unmatched
2021-10-13T22:21:08-ac2ed98-b90d258/linux-riscv64-unmatched
2021-10-13T04:56:02-378b9e1-e8f99da/linux-riscv64-unmatched
2021-10-12T06:55:50-c83725b-d887d3b/linux-riscv64-unmatched
2021-10-11T22:57:32-c83725b-d90f0b9/linux-riscv64-unmatched
2021-10-09T23:29:26-ee04797-b99abf3/linux-riscv64-unmatched
2021-10-09T17:34:04-ee04797-ba2c9fe/linux-riscv64-unmatched
2021-10-09T01:04:29-ee04797-e1c294a/linux-riscv64-unmatched
2021-10-08T22:21:41-ee04797-74abcab/linux-riscv64-unmatched
2021-10-08T21:38:44-c5188f2-74abcab/linux-riscv64-unmatched
2021-10-08T02:09:58-c5188f2-e74db46/linux-riscv64-unmatched
2021-10-08T00:24:52-c5188f2-78d749f/linux-riscv64-unmatched
2021-10-07T03:41:40-d477ef3-6f74ed0/linux-riscv64-unmatched
2021-10-07T00:39:17-d477ef3-812a33d/linux-riscv64-unmatched
2021-10-05T07:32:41-81efdbc-d55009c/linux-riscv64-unmatched
2021-10-05T03:23:35-81efdbc-123393a/linux-riscv64-unmatched
2021-10-05T01:30:56-36e7bf9-123393a/linux-riscv64-unmatched
2021-10-05T00:29:40-36e7bf9-81b7ec1/linux-riscv64-unmatched
2021-10-04T03:19:02-ccaa907-3bbc823/linux-riscv64-unmatched
2021-10-02T16:05:55-0ebff1a-a7fe161/linux-riscv64-unmatched
2021-10-02T13:52:59-0ebff1a-07a7c6f/linux-riscv64-unmatched
2021-10-02T00:44:24-0ebff1a-afe43f1/linux-riscv64-unmatched
2021-10-01T21:26:43-0ebff1a-0d65c27/linux-riscv64-unmatched
2021-10-01T20:36:29-942994f-0d65c27/linux-riscv64-unmatched
2021-10-01T19:30:53-13c407c-0d65c27/linux-riscv64-unmatched
2021-10-01T14:06:36-e89823e-96d3ba8/linux-riscv64-unmatched
2021-10-01T04:28:36-e89823e-6a79f35/linux-riscv64-unmatched
2021-09-30T20:30:12-1c35f2a-c035d82/linux-riscv64-unmatched
2021-09-30T18:10:18-1c35f2a-205640e/linux-riscv64-unmatched
2021-09-30T16:43:32-1c35f2a-9112d29/linux-riscv64-unmatched
2021-09-30T01:32:54-1c35f2a-6656269/linux-riscv64-unmatched
2021-09-29T22:14:44-1c35f2a-2d6d558/linux-riscv64-unmatched
2021-09-29T19:22:48-1c35f2a-82ac9ab/linux-riscv64-unmatched
2021-09-29T19:20:39-7d467dc-82ac9ab/linux-riscv64-unmatched
2021-09-28T23:59:17-df9a164-435718e/linux-riscv64-unmatched
2021-09-28T22:34:40-0df0ca0-b8a6017/linux-riscv64-unmatched
2021-09-28T22:17:57-7898fe6-b8a6017/linux-riscv64-unmatched
2021-09-28T21:42:57-da36f79-b8a6017/linux-riscv64-unmatched
2021-09-28T03:21:58-ba6b94c-534dfb2/linux-riscv64-unmatched
2021-09-28T00:35:10-ba6b94c-850a4ff/linux-riscv64-unmatched
2021-09-27T22:57:08-ba6b94c-12e8ffc/linux-riscv64-unmatched
2021-09-24T19:46:09-939195f-cfd0868/linux-riscv64-unmatched
2021-09-24T10:51:48-6d1e33f-fe8347b/linux-riscv64-unmatched
2021-09-22T03:45:00-b98090b-051df0d/linux-riscv64-unmatched
2021-09-22T01:41:09-b98090b-3664950/linux-riscv64-unmatched
2021-09-21T03:32:29-fe076c8-c7543e5/linux-riscv64-unmatched
2021-09-21T02:24:06-91c880c-986f8ea/linux-riscv64-unmatched
2021-09-19T16:34:52-7559231-771b8ea/linux-riscv64-unmatched
2021-09-19T02:43:09-2758b04-771b8ea/linux-riscv64-unmatched
2021-09-18T06:04:41-2758b04-c894b44/linux-riscv64-unmatched
2021-09-17T23:44:10-2758b04-4b654c0/linux-riscv64-unmatched
2021-09-17T21:29:32-2758b04-3fa7dbe/linux-riscv64-unmatched
2021-09-17T17:58:44-2758b04-6d02ce8/linux-riscv64-unmatched
2021-09-16T14:25:50-1a7ca93-04f5116/linux-riscv64-unmatched
2021-09-15T22:53:42-1a7ca93-cfa233d/linux-riscv64-unmatched
2021-09-15T20:29:43-1a7ca93-03df68d/linux-riscv64-unmatched
2021-09-15T18:56:22-1a7ca93-6196979/linux-riscv64-unmatched
2021-09-15T14:06:14-4ba3eff-e4dfd78/linux-riscv64-unmatched
2021-09-15T09:43:47-02e5238-e4dfd78/linux-riscv64-unmatched
2021-09-15T03:29:46-0cffec9-4847c47/linux-riscv64-unmatched
2021-09-14T19:06:02-258ee27-181e8cd/linux-riscv64-unmatched
2021-09-14T14:27:57-384e5da-181e8cd/linux-riscv64-unmatched
2021-09-12T01:06:53-915f620-0d8a4bf/linux-riscv64-unmatched
2021-09-11T05:05:56-915f620-23832ba/linux-riscv64-unmatched
2021-09-10T02:44:36-295a39b-2091bd3/linux-riscv64-unmatched
2021-09-09T21:49:46-295a39b-c981874/linux-riscv64-unmatched
2021-09-08T19:08:28-2cae65c-65f0d24/linux-riscv64-unmatched
2021-09-08T17:59:29-0a6f080-c8d4fe2/linux-riscv64-unmatched
2021-09-07T17:50:42-3604566-8118866/linux-riscv64-unmatched
2021-09-03T22:56:58-d39bbca-4957976/linux-riscv64-unmatched
2021-09-03T18:01:36-4e109c5-52aef05/linux-riscv64-unmatched
2021-09-03T17:12:04-7391fc1-52aef05/linux-riscv64-unmatched
2021-09-02T19:56:24-3b801c8-065f380/linux-riscv64-unmatched
2021-09-02T18:21:15-3b801c8-7609b50/linux-riscv64-unmatched
2021-09-02T01:23:38-8373dc3-1bd35fa/linux-riscv64-unmatched

CC @findleyr

@bcmills
Copy link
Member Author

bcmills commented Nov 3, 2021

Ideally we should skip the slower tests in -short mode (which most builders run), and/or change the tests to use deadlines more appropriate to each builder (I have a suspicion that this deadline may be hard-coded somewhere).

In the meantime, I'll update internal/testenv to treat this builder as too slow for gopls tests. 😩

@bcmills bcmills added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. release-blocker labels Nov 3, 2021
@bcmills bcmills added this to the Go1.18 milestone Nov 3, 2021
@findleyr
Copy link
Contributor

findleyr commented Nov 3, 2021

Thanks Bryan.

Feel free to leave these to me. I'll get to them before beta1.

@bcmills bcmills added the gopls Issues related to the Go language server, gopls. label Nov 3, 2021
@bcmills
Copy link
Member Author

bcmills commented Nov 3, 2021

I appreciate that, but honestly I'd rather just go ahead and take care of it — I want to get the dashboards clean enough that I can see whether there are any other release-blockers remaining.

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Nov 3, 2021
@gopherbot
Copy link

gopherbot commented Nov 3, 2021

Change https://golang.org/cl/361155 mentions this issue: internal/testenv: treat linux-riscv64-unmatched as a slow builder

gopherbot pushed a commit to golang/tools that referenced this issue Nov 3, 2021
For golang/go#49321

Change-Id: I36e1b26a52956b6b2a9a2a655934aba853759162
Reviewed-on: https://go-review.googlesource.com/c/tools/+/361155
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
@bcmills bcmills modified the milestones: Go1.18, Backlog Nov 3, 2021
@bcmills
Copy link
Member Author

bcmills commented Nov 3, 2021

The tests that were timing out should now be bypassed on this builder. (Moving to backlog to consider longer-term fixes that don't need to special-case the builders.)

rinchsan pushed a commit to rinchsan/gosimports that referenced this issue Aug 14, 2022
For golang/go#49321

Change-Id: I36e1b26a52956b6b2a9a2a655934aba853759162
Reviewed-on: https://go-review.googlesource.com/c/tools/+/361155
Trust: Bryan C. Mills <bcmills@google.com>
Run-TryBot: Bryan C. Mills <bcmills@google.com>
gopls-CI: kokoro <noreply+kokoro@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants