Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time: ParseInLocation error [1.17 backport] #49407

Closed
gopherbot opened this issue Nov 6, 2021 · 4 comments
Closed

time: ParseInLocation error [1.17 backport] #49407

gopherbot opened this issue Nov 6, 2021 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.17.4

Comments

@gopherbot
Copy link

@zhouguangyuan0718 requested issue #49284 to be considered for backport to the next 1.17 minor release.

@gopherbot please open backport to 1.16 and 1.17
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Nov 6, 2021
@gopherbot gopherbot mentioned this issue Nov 6, 2021
Closed
@gopherbot gopherbot added this to the Go1.17.4 milestone Nov 6, 2021
@gopherbot
Copy link
Author

Change https://golang.org/cl/361955 mentions this issue: [release-branch.go1.17] time: fix looking for zone offset when date is close to a zone transition

@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Nov 24, 2021
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Nov 24, 2021
@heschi
Copy link
Contributor

heschi commented Nov 24, 2021

@ianlancetaylor This cherrypick's CL still needs review.

@ianlancetaylor
Copy link
Contributor

Now reviewed, needs a Trust+1.

@gopherbot
Copy link
Author

Closed by merging b7651e5 to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue Nov 29, 2021
@zhouguangyuan0718 @ianlancetaylor
[release-branch.go1.17] time: fix looking for zone offset when date i…
b7651e5 
…s close to a zone transition

The old implement passed start - 1 or end in func lookup to adjust the offset.But if the time is close to the last zoneTrans, like the issue, testcase and comment, the "start" from lookup will be omega. It can't be adjusted correctly.

Fixes #49407

Change-Id: Ibaf82dc4db6d5dd3279796f003d2b19c38a26341
Reviewed-on: https://go-review.googlesource.com/c/go/+/360616
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Trust: Robert Findley <rfindley@google.com>
(cherry picked from commit 90462df)
Reviewed-on: https://go-review.googlesource.com/c/go/+/361955
Trust: Dmitri Shuralyov <dmitshur@golang.org>
@knz knz mentioned this issue Jan 10, 2022
Closed
@golang golang locked and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.17.4
Development

No branches or pull requests
4 participants
@toothrot @ianlancetaylor @gopherbot @heschi