Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exp/vulncheck: no unique module sharing in Binary #50030

Closed
zpavlinovic opened this issue Dec 7, 2021 · 1 comment
Closed

exp/vulncheck: no unique module sharing in Binary #50030

zpavlinovic opened this issue Dec 7, 2021 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@zpavlinovic
Copy link
Contributor

Binary API currently does not return module information, which is internally modeled suboptimally. Unique modules are not represented by a unique pointer value, which could cause issues if Binary at some point starts returning module and package information.
@toothrot toothrot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 8, 2021
@toothrot toothrot added this to the Backlog milestone Dec 8, 2021
@jba
Copy link
Contributor

jba commented Apr 13, 2022

Fixed by https://go.dev/cl/400118.

@jba jba closed this as completed Apr 13, 2022
@golang golang locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@toothrot @zpavlinovic @julieqiu @gopherbot @jba