Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/poll: deadlock in Read on arm64 when an FD is closed [1.17 backport] #50611

Open
gopherbot opened this issue Jan 14, 2022 · 2 comments
Open

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Jan 14, 2022

@bcmills requested issue #45211 to be considered for backport to the next 1.17 minor release.

@gopherbot, please backport to 1.17 and 1.16: this is a race condition that can result in deadlocks on ARM64 in any process that relies on Close unblocking a read. It is tricky to diagnose (and hard to reproduce reliably), and there is no apparent workaround for users on ARM64 machines.

@rsc
Copy link
Contributor

@rsc rsc commented Jan 19, 2022

I'd feel better about a backport if we had more data showing that the crashes really have stopped.

@bcmills
Copy link
Member

@bcmills bcmills commented Jan 19, 2022

Unfortunately the crashes only reproduced on a very small number of builders, and even then not in a way we could reproduce easily outside of the builder environment, which can be arbitrarily different from even a gomote due to system load, test sharding, and the process environment (see #32430). To make matters worse, because of the reduced rate of CLs for the code freeze we aren't getting very many organic test runs on the builders we do have.

Perhaps we should revisit a backport after the tree reopens for 1.19 development, so that we can have a larger body of test runs to compare?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants