cmd/go: `unexpected EOF` error in proxy fetch path lacks error context #52727

bcmills · 2022-05-05T15:12:22Z

            # get https://proxy.golang.org/golang.org/x/xerrors/@v/v0.0.0-20191011141410-1b5146add898.mod
            # get https://proxy.golang.org/golang.org/x/xerrors/@v/v0.0.0-20191011141410-1b5146add898.mod: 200 OK (0.003s)
            golang.org/x/tools/cmd/goimports imports
            	golang.org/x/sys/execabs: golang.org/x/sys@v0.0.0-20211019181941-9d821ace8654: unexpected EOF
            # get https://proxy.golang.org/golang.org/x/mod/@v/list
            # get https://proxy.golang.org/golang.org/x/xerrors/@v/list
            # get https://proxy.golang.org/golang.org/x/xerrors/@v/list: 200 OK (0.013s)

This may well be a bug in the proxy.golang.org server, but without more detail from the error message we don't have a good way to track it down. Step one is to improve the error message to describe exactly which URL produced the unexpected EOF error.

The text was updated successfully, but these errors were encountered:

bcmills · 2022-05-06T13:53:13Z

Looks like this bug is pretty old. The first occurrence I could find in the logs is from 2019. 😅

greplogs -l -e '.*: [a-zA-Z0-9]+\.[a-zA-Z0-9]+[^@]*@v\d+\.\d+\.\d+[^:]*: unexpected EOF'

bcmills · 2022-05-16T18:11:42Z

I think this is coming from the net/http package: a mismatched Content-Length header on the HTTP response seems to provoke an unexpected EOF error without additional detail (https://go.dev/play/p/nJN-O8xOT1W).

That appears to come from here:
https://cs.opensource.google/go/go/+/master:src/net/http/transfer.go;l=862-866;drc=0537a74b76fcab1398da6699c3ff7411fef8fbe7

The error text is not in line with Effective Go's guidance ”to provide detailed error information”, but it almost certainly cannot be changed now, so we need to wrap the error on the caller side.

gopherbot · 2022-05-16T20:16:52Z

Change https://go.dev/cl/406675 mentions this issue: cmd/go/internal/modfetch: wrap errors from HTTP response bodies

bcmills added help wanted NeedsInvestigation GoCommand modules labels May 5, 2022

bcmills added this to the Backlog milestone May 5, 2022

bcmills assigned bcmills and unassigned bcmills May 5, 2022

bcmills mentioned this issue May 16, 2022

proposal: net/http: thoughts for Go 2.0 #5465

Open

bcmills self-assigned this May 16, 2022

bcmills removed this from the Backlog milestone May 16, 2022

bcmills added this to the Go1.19 milestone May 16, 2022

bcmills added NeedsFix and removed help wanted labels May 16, 2022

gopherbot removed the NeedsInvestigation label May 16, 2022

golang / go Public

cmd/go: `unexpected EOF` error in proxy fetch path lacks error context #52727

cmd/go: `unexpected EOF` error in proxy fetch path lacks error context #52727

bcmills commented May 5, 2022 •

edited

bcmills commented May 6, 2022

bcmills commented May 16, 2022

gopherbot commented May 16, 2022

golang / go Public

cmd/go: unexpected EOF error in proxy fetch path lacks error context #52727

cmd/go: unexpected EOF error in proxy fetch path lacks error context #52727

Comments

bcmills commented May 5, 2022 • edited

bcmills commented May 6, 2022

bcmills commented May 16, 2022

gopherbot commented May 16, 2022

cmd/go: `unexpected EOF` error in proxy fetch path lacks error context #52727

cmd/go: `unexpected EOF` error in proxy fetch path lacks error context #52727

bcmills commented May 5, 2022 •

edited