Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: module index [freeze exception] #52876

Open
matloob opened this issue May 12, 2022 · 4 comments
Open

cmd/go: module index [freeze exception] #52876

matloob opened this issue May 12, 2022 · 4 comments
Labels
NeedsFix
Milestone

Comments

@matloob
Copy link
Contributor

@matloob matloob commented May 12, 2022

Hi,

I'd like to request a freeze exception for the work on the cmd/go module index. All the CLs have been mailed out but we need a little more time to get the reviews through.

Thanks!
Michael

@mvdan
Copy link
Member

@mvdan mvdan commented May 12, 2022

What is the module index? Any links you can share?

@thepudds
Copy link

@thepudds thepudds commented May 12, 2022

Hi @mvdan, there is a stack of CLs here, but I’m not sure if there is a general overview somewhere:

https://go-review.googlesource.com/c/go/+/398415/30

As I understand it, it is to reduce reliance on scanning the existing module cache, presumably for performance reasons.

@seankhliao seankhliao changed the title cmd/go: freeze exception for module index cmd/go: module index [freeze exception] May 12, 2022
@seankhliao seankhliao added the NeedsDecision label May 12, 2022
@seankhliao seankhliao added this to the Go1.19 milestone May 12, 2022
@seankhliao
Copy link
Contributor

@seankhliao seankhliao commented May 12, 2022

@heschi
Copy link
Contributor

@heschi heschi commented May 13, 2022

Approved: the go command doesn't get much testing until the beta anyway, and the change doesn't seem likely to cause problems for other parts of the project.

@dmitshur dmitshur added NeedsFix and removed NeedsDecision labels May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix
Projects
None yet
Development

No branches or pull requests

6 participants