Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestProfBuf failures #56196

Open
gopherbot opened this issue Oct 13, 2022 · 4 comments
Open

runtime: TestProfBuf failures #56196

gopherbot opened this issue Oct 13, 2022 · 4 comments
Assignees
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@gopherbot
Copy link

gopherbot commented Oct 13, 2022

#!watchflakes
post <- pkg == "runtime" && test == "TestProfBuf"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestProfBuf (0.74s)
    profbuf_test.go:62: myTags is 0x1230000
    --- FAIL: TestProfBuf/BlockingWriteRead (0.73s)
        profbuf_test.go:37: unexpected profile read:
            have data [0x5 0x63 0x0 0x0 0x1]
            want data [0x8 0x63 0x65 0x66 0xc9 0xca 0xcb 0xcc]
            have tags [0x0]
            want tags [0x1230002]
            have eof=false, want false

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 13, 2022
@gopherbot
Copy link
Author

gopherbot commented Oct 13, 2022

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "runtime" && test == "TestProfBuf"
2022-10-06 04:37 openbsd-arm-jsing go@b314eea4 runtime.TestProfBuf (log)
--- FAIL: TestProfBuf (0.74s)
    profbuf_test.go:62: myTags is 0x1230000
    --- FAIL: TestProfBuf/BlockingWriteRead (0.73s)
        profbuf_test.go:37: unexpected profile read:
            have data [0x5 0x63 0x0 0x0 0x1]
            want data [0x8 0x63 0x65 0x66 0xc9 0xca 0xcb 0xcc]
            have tags [0x0]
            want tags [0x1230002]
            have eof=false, want false

watchflakes

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Oct 13, 2022
@mknyszek
Copy link
Contributor

mknyszek commented Oct 19, 2022

@prattmic notes that CPU profile is broken on openbsd-arm, so as long as we only see issues there, this is probably not worth tracking other than to skip these tests. Assigning to @prattmic who volunteered to do that.

@mknyszek mknyszek added this to the Backlog milestone Oct 19, 2022
@prattmic
Copy link
Member

prattmic commented Oct 19, 2022

Actually, this just tests the buffer itself, it doesn't do profiling. I'll take a closer look.

@prattmic
Copy link
Member

prattmic commented Oct 21, 2022

The failing case is this one https://cs.opensource.google/go/go/+/master:src/runtime/profbuf_test.go;l=144-146;drc=b788fd80e68addd181983ca589d28bc1075f4a36.

The timestamp (99/0x63) is correct, but the length (got 5 want 8) and header/stack data are incorrect. Nothing stands out here, I'd like to see more failures to see if this is a pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: Todo
Status: No status
Development

No branches or pull requests

3 participants