Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: upgrade and/or turn down builders running Debian “Stretch” #56414

Closed
bcmills opened this issue Oct 25, 2022 · 13 comments
Closed

x/build: upgrade and/or turn down builders running Debian “Stretch” #56414

bcmills opened this issue Oct 25, 2022 · 13 comments
Assignees
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@bcmills
Copy link
Member

bcmills commented Oct 25, 2022

According to https://wiki.debian.org/LTS, Debian 9 “Stetch” reached end-of-life on June 30, 2022.

Unfortunately, our builders seem to still be using a Stretch-based image as the default linux for a variety of builders:
https://cs.opensource.google/search?q=%22host-linux-amd64-stretch%22&sq=&ss=go%2Fx%2Fbuild

Since this Debian version is no longer supported upstream, we should upgrade the various builders to a supported release and drop the version-specific linux-.*-stretch builders.

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Oct 25, 2022
@bcmills bcmills changed the title x/build: upgradet and/or turn down builders running Debian “Stretch” x/build: upgrade and/or turn down builders running Debian “Stretch” Oct 25, 2022
@gopherbot gopherbot added this to the Unreleased milestone Oct 25, 2022
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 25, 2022
@gopherbot
Copy link

Change https://go.dev/cl/445356 mentions this issue: cmd/go: make vcstest repo scripts compatible with old Mercurial versions

@golang golang deleted a comment from gopherbot Oct 25, 2022
gopherbot pushed a commit that referenced this issue Oct 25, 2022
The scripts added in CL 421455 passed on the TryBots, but failed on
the "-stretch" builders, which supply Mercurial 4.0
(released 2016-11-01).

Debian 9 “Stretch” has been at end-of-life since June 30, 2022, but
until we can turn down the outdated builders (#56414) we should keep
them passing tests.

For #27494.
Updates #56414.

Change-Id: I9df0ed452dfbfaeb1b4c0d869d02dd9ed21b3ff6
Reviewed-on: https://go-review.googlesource.com/c/go/+/445356
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@heschi heschi self-assigned this Oct 25, 2022
@heschi
Copy link
Contributor

heschi commented Oct 26, 2022

We can't get rid of Stretch entirely until 1.18 ages out but we can certainly move the non-versioned builders to Bullseye.

@gopherbot
Copy link

Change https://go.dev/cl/445617 mentions this issue: all: switch vmx-enabled Debian over to Bullseye

@gopherbot
Copy link

Change https://go.dev/cl/445616 mentions this issue: dashboard/builders: upgrade non-specific Linux builders to Stretch

@gopherbot
Copy link

Change https://go.dev/cl/445619 mentions this issue: dashboard,internal/releasetargets: target Bullseye for Go 1.20

@gopherbot
Copy link

Change https://go.dev/cl/445618 mentions this issue: dashboard/builders: disable Stretch builders on master/1.20

gopherbot pushed a commit to golang/build that referenced this issue Oct 28, 2022
We have to update the non-versioned builders sometime, and now seems as
good as any.

This is just an easy first step, still need to figure out vmx and
whether to disable the stretch builders on master/1.20.

For golang/go#56414.

Change-Id: I7f1ce4faa9c6fa1595b7a0c3c72d451b1d18e5f4
Reviewed-on: https://go-review.googlesource.com/c/build/+/445616
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Oct 28, 2022
I basically just did a find-and-replace, and we'll see if it works?

I've updated and built the new disk images so this should be ready to
deploy.

For golang/go#56414.

Change-Id: Iaac41d6f7a1244c3682e624f7a4ee4fa7477dfa1
Reviewed-on: https://go-review.googlesource.com/c/build/+/445617
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Oct 28, 2022
Stretch was EOL at the beginning of the 1.20 cycle, so according to our
draft policy we should no longer build on it.

For golang/go#56414.

Change-Id: Ibac0d5438cf9e0b8f24cde7b38bb3f6cdc7a5096
Reviewed-on: https://go-review.googlesource.com/c/build/+/445618
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Auto-Submit: Heschi Kreinick <heschi@google.com>
gopherbot pushed a commit to golang/build that referenced this issue Oct 28, 2022
For golang/go#56414, golang/go#40561.

Change-Id: If799e9ea7171d33acc57c53442ca33f51f803d3c
Reviewed-on: https://go-review.googlesource.com/c/build/+/445619
Auto-Submit: Heschi Kreinick <heschi@google.com>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/446183 mentions this issue: dashboard/builders: don't run mobile on Stretch builders, clean up

gopherbot pushed a commit to golang/build that referenced this issue Oct 28, 2022
I forgot to check buildRepoByDefault on the Stretch builders, so they
started running x/mobile.

Also noticed a ton of obsolete builders/checks, clean them out while I'm
at it. In the tests, clear out very old version checks, and replace
"arbitrary release branch" versions with go1.99 rather than whatever
happened to be current when the test case was written.

For golang/go#56414.

Change-Id: I88eeeaec5d166d1ac1a3938dbc26870ff8d4b33a
Reviewed-on: https://go-review.googlesource.com/c/build/+/446183
Auto-Submit: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@heschi
Copy link
Contributor

heschi commented Oct 28, 2022

I believe this is done. Let me know if you spot a mistake.

@heschi heschi closed this as completed Oct 28, 2022
@heschi heschi reopened this Oct 31, 2022
@heschi
Copy link
Contributor

heschi commented Oct 31, 2022

Turns out I broke android-*-emu. cc @golang/android.

2022/10/31 15:58:38 loading imports: exit status 2
go: no such tool "compile"
exitcode=1
FAIL	cmd/api	0.734s
FAIL
go tool dist: Failed: exit status 1

...should cmd/api tests even be running?

@bcmills
Copy link
Member Author

bcmills commented Oct 31, 2022

That failure mode looks like it could have been introduced by CL 432535. Coincidental timing?

@heschi
Copy link
Contributor

heschi commented Oct 31, 2022

Oh, true. I definitely rolled out the changes before 23:35 that day. cc @matloob to offer an opinion but I think you're right.

@bcmills
Copy link
Member Author

bcmills commented Oct 31, 2022

I've mailed CL 446638 to rule that out one way or another.

@heschi
Copy link
Contributor

heschi commented Oct 31, 2022

Given that it passed trybots, closing. Thanks.

@heschi heschi closed this as completed Oct 31, 2022
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Nov 3, 2022
The scripts added in CL 421455 passed on the TryBots, but failed on
the "-stretch" builders, which supply Mercurial 4.0
(released 2016-11-01).

Debian 9 “Stretch” has been at end-of-life since June 30, 2022, but
until we can turn down the outdated builders (golang#56414) we should keep
them passing tests.

For golang#27494.
Updates golang#56414.

Change-Id: I9df0ed452dfbfaeb1b4c0d869d02dd9ed21b3ff6
Reviewed-on: https://go-review.googlesource.com/c/go/+/445356
Auto-Submit: Bryan Mills <bcmills@google.com>
Reviewed-by: Russ Cox <rsc@golang.org>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Archived in project
Development

No branches or pull requests

3 participants