Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: reopen tree for Go 1.24 development #67586

Closed
5 tasks done
cagedmantis opened this issue May 22, 2024 · 12 comments
Closed
5 tasks done

all: reopen tree for Go 1.24 development #67586

cagedmantis opened this issue May 22, 2024 · 12 comments
Assignees
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. NeedsFix The path to resolution is known, but the work has not been done. umbrella
Milestone

Comments

@cagedmantis
Copy link
Contributor

cagedmantis commented May 22, 2024

Current Tree Status: Tree is open for Go 1.24 development (golang-dev announcement)

This is a tracking issue for the upcoming task of reopening the tree for Go 1.24 development. (It's created a little early to create room for planning early CLs/branches to land during tree reopening.) The estimated date for the tree reopening is mid July 2024.

As usual, the tree will initially be open to changes that must land early:

CC @golang/release.

@cagedmantis cagedmantis added NeedsFix The path to resolution is known, but the work has not been done. early-in-cycle A change that should be done early in the 3 month dev cycle. umbrella labels May 22, 2024
@cagedmantis cagedmantis added this to the Go1.24 milestone May 22, 2024
@mvdan
Copy link
Member

mvdan commented May 23, 2024

When you post tree reopening issues like this one, could you please include when you expect it to happen? Given https://go.dev/wiki/Go-Release-Cycle, I would expect mid July, but that might not be obvious to everyone.

@cagedmantis
Copy link
Contributor Author

@mvdan That sounds perfectly reasonable. Thanks for suggesting it.

@dmitshur dmitshur self-assigned this Jul 22, 2024
@dmitshur dmitshur pinned this issue Jul 22, 2024
@dmitshur
Copy link
Contributor

We've reached the time to reopen. I'll be starting on this soon. So far it seems there aren't any large changes that need special treatment; please comment if we missed something that should land early in a specific order to reduce merge conflicts.

@cuonglm
Copy link
Member

cuonglm commented Jul 22, 2024

We've reached the time to reopen. I'll be starting on this soon. So far it seems there aren't any large changes that need special treatment; please comment if we missed something that should land early in a specific order to reduce merge conflicts.

Is fix for 1.23 needs to be backport?

For example, CL https://go.dev/cl/599675 is land after rc2, but it's for 1.23 release.

@dmitshur
Copy link
Contributor

dmitshur commented Jul 22, 2024

@cuonglm We'll soon merge everything on the main branch, up to but not including the upcoming "internal/goversion: update Version to 1.24" CL, to release-branch.go1.23. Since CL 599675 is already submitted, no need for action on your side. But in the near future after the goversion CL lands, if something is intended for 1.23 and permitted by freeze policy it will indeed need to be cherry-picked to release-branch.go1.23 individually. See https://go.dev/s/release#july--january-week-3-work-on-the-next-release-begins for details.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/600176 mentions this issue: internal/goversion: update Version to 1.24

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/600177 mentions this issue: doc: initialize next directory for Go 1.24

gopherbot pushed a commit that referenced this issue Jul 22, 2024
Go 1.24 is in the process of being opened for development (to be
eventually released). This change marks the very beginning of its
development cycle, updating the Version value accordingly.

For #40705.
For #67586.

Change-Id: Ibd194f229e7dbd25bc2713f86330fab50ea1dfaa
Reviewed-on: https://go-review.googlesource.com/c/go/+/600176
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot pushed a commit that referenced this issue Jul 22, 2024
Following the "For the release team" steps in README:

	cd doc
	cp -R initial/ next
	$EDITOR next/1-intro.md

Dropped '*' from the cp -R command to avoid needing to
create an empty next directory with a separate command.

For #68545.
For #67586.

Change-Id: I25215bc35a043e0f26d4a86ffe66eb3c26348fef
Reviewed-on: https://go-review.googlesource.com/c/go/+/600177
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@dmitshur
Copy link
Contributor

dmitshur commented Jul 22, 2024

There were about 7 9 CLs that were already approved and marked AutoSubmit+1, but blocked on wait-release. They're now in. I'll wait to see the results on the post-submit dashboard and follow up before proceeding with the rest of the steps in the tree re-opening sequence.

@cuonglm
Copy link
Member

cuonglm commented Jul 23, 2024

@dmitshur CL https://go-review.googlesource.com/c/go/+/560955 could be land in for early in cycle, too.

@dmitshur
Copy link
Contributor

dmitshur commented Jul 23, 2024

The tree is now open. See announcement on golang-dev. Thanks.

(I'll unpin this issue after some time passes.)

@thanm
Copy link
Contributor

thanm commented Jul 23, 2024

At what point will we change the go.mod version line to 1.24? Not sure if this falls into the realm of this issue, or if it is being tracked elsewhere. Thanks.

@dmitshur
Copy link
Contributor

@thanm That generally happens as part of issue #36905 which is early-in-cycle and we'll get to soon. It's fine to do it separately even sooner if needed.

@dmitshur dmitshur unpinned this issue Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. NeedsFix The path to resolution is known, but the work has not been done. umbrella
Projects
Status: Done
Development

No branches or pull requests

6 participants