-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go/internal/get: fix regexes for "any" character matching #23755
Conversation
This PR (HEAD: 531de6d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/92997 to see it. Tip: You can toggle comments from me using the |
Gobot Gobot has posted review comments at golang.org/cl/92997. |
Andrew Bonventre has posted review comments at golang.org/cl/92997. |
Brad Fitzpatrick has posted review comments at golang.org/cl/92997. |
This PR (HEAD: 75bd338) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/go/+/92997 to see it. Tip: You can toggle comments from me using the |
Piyush Mishra has posted review comments at golang.org/cl/92997. |
Dmitri Shuralyov has posted review comments at golang.org/cl/92997. |
Dmitri Shuralyov has posted review comments at golang.org/cl/92997. |
Brad Fitzpatrick has posted review comments at golang.org/cl/92997. |
Andrew Bonventre has posted review comments at golang.org/cl/92997. |
Brad Fitzpatrick has posted review comments at golang.org/cl/92997. |
Andrew Bonventre has posted review comments at golang.org/cl/92997. |
Piyush Mishra has posted review comments at golang.org/cl/92997. |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Andrew Bonventre: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Brad Fitzpatrick: Patch Set 1: This would also need a test. Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Piyush Mishra: Patch Set 2:
Added tests and also removed the leading space with a force push. Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Dmitri Shuralyov: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Dmitri Shuralyov: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Brad Fitzpatrick: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Andrew Bonventre: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Brad Fitzpatrick: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Andrew Bonventre: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Piyush Mishra: Patch Set 2: (2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Andrew Bonventre: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Brad Fitzpatrick: Patch Set 1: This would also need a test. Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Piyush Mishra: Patch Set 2:
Added tests and also removed the leading space with a force push. Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Dmitri Shuralyov: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Dmitri Shuralyov: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Brad Fitzpatrick: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Andrew Bonventre: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Brad Fitzpatrick: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Andrew Bonventre: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Piyush Mishra: Patch Set 2: (2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Apologies for the duplicate posts on this. |
Message from Andrew Bonventre: Patch Set 2: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Gobot Gobot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=bdb55692 Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Message from Gobot Gobot: Patch Set 2: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/92997. |
Minor bug: `hubajazz.net` and `gitbapache.org` would match, probably shouldn't GitHub-Last-Rev: 75bd338 GitHub-Pull-Request: #23755 Change-Id: Ie9c9ab1c15364eccdab8cf3b106b9c370e7f532f Reviewed-on: https://go-review.googlesource.com/92997 Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This PR is being closed because golang.org/cl/92997 has been merged. |
Minor bug:
hubajazz.net
andgitbapache.org
would match, probably shouldn't