Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/ast: add Filter func test on AST #26023

Closed
wants to merge 5 commits into from
Closed

go/ast: add Filter func test on AST #26023

wants to merge 5 commits into from

Conversation

arthurkushman
Copy link

The existing implementation of Filter should behave as if it removes (filter out) comments from parsed AST (by providing filter Node argument) leaving the rest untouched.

The TestFilter - checks for length differences of both filtered and unfiltered as general and then for excluded from ASTree.

Add FilterTest #26022

@arthurkushman
ast_test: add Filter func test on AST
38ad99d 
The existing implementation of Filter should behave as if it removes (filter out) comments from parsed AST (by providing filter Node argument) leaving the rest untouched.

The TestFilter - checks for length differences of both filtered and unfiltered as general and then for excluded from ASTree.
@arthurkushman
ast_test: add Filter func test on AST
182c9e3 
The existing implementation of Filter should behave as if it removes (filter out) comments from parsed AST (by providing filter Node argument) leaving the rest untouched.

The TestFilter - checks for length differences of both filtered and unfiltered as general and then for excluded from ASTree.

Add FilterTest golang#26022
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. label Jun 23, 2018
@arthurkushman
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Jun 23, 2018
@arthurkushman arthurkushman changed the title ast_test: add Filter func test on AST go/ast: add Filter func test on AST Jun 23, 2018
@gopherbot
Copy link
Contributor

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/120675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Griesemer:

Patch Set 1: Code-Review-1

(11 comments)

This code needs some work.

Please don’t reply on this GitHub thread. Visit golang.org/cl/120675.
After addressing review feedback, remember to publish your drafts!

@arthurkushman
Merge branch 'master' into test_filter_on_commentmap
44985f8
@arthurkushman
go/ast: add Filter func test on AST
924c565 
Fixed issues with fragile implementation for TestFilter applying additional check on x var, added new comments source, changed some obscure comments, added new lines before comments

Fix FilterTest golang#26022
@gopherbot
Copy link
Contributor

Message from Gerrit Bot:

Uploaded patch set 3: New patch set was added with same tree, parent, and commit message as Patch Set 2.

Please don’t reply on this GitHub thread. Visit golang.org/cl/120675.
After addressing review feedback, remember to publish your drafts!

@gopherbot gopherbot force-pushed the master branch 12 times, most recently from 4016de0 to d2f663c Compare July 18, 2018 19:56
@gopherbot gopherbot force-pushed the master branch 4 times, most recently from e3f15e3 to d286d4b Compare July 19, 2018 05:28
@gopherbot gopherbot force-pushed the master branch 5 times, most recently from 9092511 to 95c3348 Compare July 19, 2018 18:17
@gopherbot gopherbot force-pushed the master branch 5 times, most recently from 0090c13 to 8fbbf63 Compare July 28, 2018 01:16
@gopherbot gopherbot force-pushed the master branch 2 times, most recently from 53bd915 to 6139019 Compare October 3, 2019 21:10
@gopherbot gopherbot force-pushed the master branch 8 times, most recently from 4a7ed1f to 0f992b9 Compare November 5, 2019 02:57
@gopherbot
Copy link
Contributor

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/120675.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gerrit User 5210:

Patch Set 1: Code-Review-1

(11 comments)

This code needs some work.

Please don’t reply on this GitHub thread. Visit golang.org/cl/120675.
After addressing review feedback, remember to publish your drafts!

@arthurkushman
Merge branch 'master' into test_filter_on_commentmap
250fccb 
# Conflicts:
#	src/go/ast/commentmap_test.go
@gopherbot
Copy link
Contributor

This PR (HEAD: 250fccb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/120675 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/120675.
After addressing review feedback, remember to publish your drafts!

@heschi heschi closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arthurkushman @googlebot @gopherbot @heschi