net: ensure WriteTo on Windows sends even zero-byte payloads

[silbinarywolf]

This builds on:
#27445

"...And then send change to fix windows internal/poll.FD.WriteTo - together with making TestUDPZeroBytePayload run again."

• alexbrainman - internal/poll: sending a zero-byte-payload UDP packet on Windows is a no-op #26668 (comment)

Fixes #26668

[gopherbot]

Message from Gerrit User 5137:

Patch Set 1:

(3 comments)

Thank you for working on this Jake!

I have made some suggestions for the commit message
as well as code changes, please take a look.

I'll also tag some reviewers too.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/132781.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gerrit User 12446:

Uploaded patch set 3: New patch set was added with same tree, parent, and commit message as Patch Set 2.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/132781.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gerrit User 28917:

Patch Set 4: Commit message was updated.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/132781.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gerrit User 28917:

Patch Set 4:

(2 comments)

I've made the changes you've requested and altered the commit message for clarity.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/132781.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gerrit User 12446:

Uploaded patch set 5: Commit message was updated.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/132781.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gerrit User 12446:

Uploaded patch set 6: New patch set was added with same tree, parent, and commit message as Patch Set 5.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/132781.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gerrit User 12446:

Uploaded patch set 7: New patch set was added with same tree, parent, and commit message as Patch Set 6.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/132781.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gerrit User 5070:

Patch Set 7: Code-Review+1

Patch Set 4:

(2 comments)

I've made the changes you've requested and altered the commit message for clarity.

I do not see your commit message changes in Gerrit (in CL 132781).

I can see the change on Github in commit 3bf2b8b
But I don't think Github bot copies, commit message contents from Github into Gerrit. I think it copies PR (your PR is 27446) message. So, please, try and change your PR message instead.

Or, alternatively, update Gerrit directly. I use https://godoc.org/golang.org/x/review/git-codereview to communicate to Gerrit. I am certain, you could just use Git to access Gerrit, but I do not know what the commands are, and I do not want to confuse you more.

Your code change LGTM. Please change CL description, and someone will submit your change.

Thank you very much.

Alex

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/132781.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gerrit User 12446:

Uploaded patch set 8: Commit message was updated.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/132781.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gerrit User 12446:

Uploaded patch set 9: New patch set was added with same tree, parent, and commit message as Patch Set 8.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/132781.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gerrit User 28917:

Patch Set 9:

Patch Set 7: Code-Review+1

Patch Set 4:

(2 comments)

I've made the changes you've requested and altered the commit message for clarity.

I do not see your commit message changes in Gerrit (in CL 132781).

I can see the change on Github in commit 3bf2b8b
But I don't think Github bot copies, commit message contents from Github into Gerrit. I think it copies PR (your PR is 27446) message. So, please, try and change your PR message instead.

Or, alternatively, update Gerrit directly. I use https://godoc.org/golang.org/x/review/git-codereview to communicate to Gerrit. I am certain, you could just use Git to access Gerrit, but I do not know what the commands are, and I do not want to confuse you more.

Your code change LGTM. Please change CL description, and someone will submit your change.

Thank you very much.

Alex

Looks like editing the PR title worked.
Let me know if you need anything else!

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/132781.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gerrit User 5070:

Patch Set 9: Run-TryBot+1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/132781.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gerrit User 5976:

Patch Set 9:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=a63962e1

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/132781.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gerrit User 5976:

Patch Set 9: TryBot-Result+1

TryBots are happy.

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/132781.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

Message from Gerrit User 5070:

Patch Set 9: Code-Review+2

---

Please don’t reply on this GitHub thread. Visit golang.org/cl/132781.
After addressing review feedback, remember to publish your drafts!

[gopherbot]

This PR is being closed because golang.org/cl/132781 has been merged.