New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regexp: add example for ReplaceAll #33489
Conversation
This PR (HEAD: cc85544) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/189137 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/189137. |
Message from Agniva De Sarker: Patch Set 1: Thanks for the change Pantelis. And congrats on your first contribution :) If you didn't know, we have a pending issue to track the addition of examples to the regexp package. Please add "Updates #21450" to this issue and the other one. And if you want, you can go ahead and add the other examples listed here #21450 (comment) to close out the issue. Please don’t reply on this GitHub thread. Visit golang.org/cl/189137. |
Message from Pantelis Sampaziotis: Patch Set 2:
Thanks, I added examples for the other 3 methods here #33497 Please don’t reply on this GitHub thread. Visit golang.org/cl/189137. |
Message from Sylvain Zimmer: Patch Set 2: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/189137. |
Message from Gobot Gobot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=69a290ff Please don’t reply on this GitHub thread. Visit golang.org/cl/189137. |
Message from Gobot Gobot: Patch Set 2: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/189137. |
Message from Agniva De Sarker: Patch Set 2: Adding some folks who can take this forward. Please don’t reply on this GitHub thread. Visit golang.org/cl/189137. |
Updates #21450 Change-Id: Ia31c20b52bae5daeb33d918234c2f0944a8aeb07 GitHub-Last-Rev: cc85544 GitHub-Pull-Request: #33489 Reviewed-on: https://go-review.googlesource.com/c/go/+/189137 Run-TryBot: Sylvain Zimmer <sylvinus@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Message from Ian Lance Taylor: Patch Set 2: Code-Review+2 Thanks. Please don’t reply on this GitHub thread. Visit golang.org/cl/189137. |
This PR is being closed because golang.org/cl/189137 has been merged. |
Updates #21450