Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regexp: add examples for FindSubmatchIndex and Longest #33497

Closed
wants to merge 2 commits into from
Closed

regexp: add examples for FindSubmatchIndex and Longest #33497

wants to merge 2 commits into from

Conversation

psampaz
Copy link
Contributor

@psampaz psampaz commented Aug 6, 2019

updates #21450

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Aug 6, 2019
@gopherbot
Copy link

This PR (HEAD: 48a0e0b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/189177 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot gopherbot mentioned this pull request Aug 6, 2019
Closed
@psampaz psampaz mentioned this pull request Aug 6, 2019
Closed
@gopherbot
Copy link

This PR (HEAD: 7daee12) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/189177 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Sylvain Zimmer:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/189177.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=d79aa735

Please don’t reply on this GitHub thread. Visit golang.org/cl/189177.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 2: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/189177.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Agniva De Sarker:

Patch Set 2:

Pantelis, FindAllIndex was just added to the repo. Would you mind rebasing with master and removing that ?

I will add Ian who can help move forward with the review.

Please don’t reply on this GitHub thread. Visit golang.org/cl/189177.
After addressing review feedback, remember to publish your drafts!

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. and removed cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. labels Sep 19, 2019
@gopherbot
Copy link

This PR (HEAD: 42c83b2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/189177 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@psampaz psampaz force-pushed the regexp_examples_longest_findsubmatchindex_findallindex branch from 42c83b2 to bb99aee Compare September 19, 2019 06:30
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. and removed cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. labels Sep 19, 2019
@gopherbot
Copy link

This PR (HEAD: bb99aee) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/189177 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

This PR (HEAD: 5329f08) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/189177 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@psampaz psampaz changed the title regexp: add examples for FindSubmatchIndex, FindAllIndex and Longest regexp: add examples for FindSubmatchIndex and Longest Sep 19, 2019
@gopherbot
Copy link

Message from Pantelis Sampaziotis:

Patch Set 6:

Patch Set 2:

Pantelis, FindAllIndex was just added to the repo. Would you mind rebasing with master and removing that ?

I will add Ian who can help move forward with the review.

Done

Please don’t reply on this GitHub thread. Visit golang.org/cl/189177.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Pantelis Sampaziotis:

Patch Set 6:

ping :)

Please don’t reply on this GitHub thread. Visit golang.org/cl/189177.
After addressing review feedback, remember to publish your drafts!

@psampaz psampaz force-pushed the regexp_examples_longest_findsubmatchindex_findallindex branch from 5329f08 to 507f555 Compare September 25, 2019 20:19
@gopherbot
Copy link

This PR (HEAD: 507f555) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/189177 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 8: Patch Set 7 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/189177.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 8: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/189177.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 8:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=b2486bb5

Please don’t reply on this GitHub thread. Visit golang.org/cl/189177.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 8: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/189177.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 28, 2019
@psampaz @ianlancetaylor
regexp: add examples for FindSubmatchIndex and Longest
9748e64 
updates #21450

Change-Id: Ibffe0dadc1e1523c55cd5f5b8a69bc1c399a255d
GitHub-Last-Rev: 507f555
GitHub-Pull-Request: #33497
Reviewed-on: https://go-review.googlesource.com/c/go/+/189177
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 8: Code-Review+2

Thanks!

Please don’t reply on this GitHub thread. Visit golang.org/cl/189177.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR is being closed because golang.org/cl/189177 has been merged.

@gopherbot gopherbot closed this Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@psampaz @gopherbot @googlebot