-
Notifications
You must be signed in to change notification settings - Fork 17.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image/jpeg: skip consecutive 0xff bytes #41875
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
This PR (HEAD: 5b1aea6) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/260837 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/260837. |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/260837. |
How long can it take? 👀 |
Message from Brad Fitzpatrick: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/260837. |
Message from Michael Mayer: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/260837. |
Any update on this? |
Why closed? |
Just closing PRs over a year old. I'll reopen, but I'll point out that the original author seems to have become unresponsive. |
@heschi what are the blockers of this getting reviewed? |
Looking at the review thread, the author would need to add test cases to the CL. |
This is a major bug. See https://twitter.com/lastzero/status/1452959588815413251. Brad asked for test files and I've uploaded them. What else do you need? 👀 |
I think you may be misunderstanding the code review process. The PR author needs to add test files, perhaps the one you uploaded, to the change before review can proceed. You are free to start your own PR or CL with tests and get it through the review process. |
Wouldn't Google have a JPEG expert who can fix a broken implementation in a core programming language? Or be so kind to ask me directly to do this instead of sitting it out and then close the issue? Go's JPEG implementation is broken. I've asked the experts as you can see. |
Hope Brad can help ✨ |
@lastzero Closing this pull request was a mistake. That mistake has been corrected. Sorry about that. Go is an open source project. It's likely that Google has a JPEG expert somewhere, but they don't work on the Go standard library. I hope that @shouldend or somebody else will pick up the change and push it forward. It shouldn't be hard. Perhaps you can do it. Thanks. |
Any updates?? |
It's a bit unclear to me whether this is actually a bug because Go doesn't handle some edge cases or that files like these are technically corrupt. Can anyone enlighten me? And is there anything I can do to move this forward? I'd be willing to create tests for this. |
WHY NOT MERGE!!! |
Go uses Gerritt for code review. See https://go.dev/doc/contribute. Essentially nobody sees comments on a GitHub pull request. Please comment instead on https://go.dev/cl/260837. Thanks. |
I also made a new one on Gerrit already that has a more complete fix and test https://go.dev/cl/571236 |
In all cases where markers are appended after the compressed data, optional 0xFF fill bytes may precede the marker
Fixes #40130