cmd/compile,runtime: panic when unsafe.Slice param is nil and > 0 #54107
Conversation
|
This PR (HEAD: c378a4f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/419755 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: 0e4b92e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/419755 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: 01777da) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/419755 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: ba98f25) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/419755 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: fee1087) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/419755 to see it. Tip: You can toggle comments from me using the |
|
Message from Matthew Dempsky: Patch Set 4: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/419755. |
cuiweixie
force-pushed
the
unsafe_slice
branch
2 times, most recently
from
b4ca475
to
b817dec
Compare
|
This PR (HEAD: b817dec) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/419755 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: 54cd2a2) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/419755 to see it. Tip: You can toggle comments from me using the |
|
Message from xie cui: Patch Set 7: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/419755. |
|
Message from xie cui: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/419755. |
|
Message from Keith Randall: Patch Set 7: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/419755. |
|
This PR (HEAD: 0cc653a) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/419755 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: a7b4bb7) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/419755 to see it. Tip: You can toggle comments from me using the |
|
This PR (HEAD: abdbf76) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/419755 to see it. Tip: You can toggle comments from me using the |
|
Message from xie cui: Patch Set 10: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/419755. |
|
Message from Ian Lance Taylor: Patch Set 10: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/419755. |
|
This PR (HEAD: fbe1d27) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/419755 to see it. Tip: You can toggle comments from me using the |
|
Message from xie cui: Patch Set 11: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/419755. |
|
Message from Keith Randall: Patch Set 11: Run-TryBot+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/419755. |
|
Message from Gopher Robot: Patch Set 11: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/419755. |
|
Message from Gopher Robot: Patch Set 11: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/419755. |
|
Message from Cuong Manh Le: Patch Set 11: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/419755. |
|
Message from xie cui: Patch Set 11: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/419755. |
|
Message from Than McIntosh: Patch Set 11: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/419755. |
|
Message from Than McIntosh: Patch Set 11: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/419755. |
…elem) == 0 and > 0 Fixes golang#54092
|
This PR (HEAD: dfd0c38) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/419755 to see it. Tip: You can toggle comments from me using the |
|
Message from Cuong Manh Le: Patch Set 12: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/419755. |
|
Message from Gopher Robot: Patch Set 12: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/419755. |
|
Message from Gopher Robot: Patch Set 12: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/419755. |
Fixes #54092 Change-Id: Ib917922ed36ee5410e5515f812737203c44f46ae GitHub-Last-Rev: dfd0c38 GitHub-Pull-Request: #54107 Reviewed-on: https://go-review.googlesource.com/c/go/+/419755 Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org>
|
This PR is being closed because golang.org/cl/419755 has been merged. |
Fixes golang#54092 Change-Id: Ib917922ed36ee5410e5515f812737203c44f46ae GitHub-Last-Rev: dfd0c38 GitHub-Pull-Request: golang#54107 Reviewed-on: https://go-review.googlesource.com/c/go/+/419755 Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org>
Fixes #54092