-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encoding/binary: ReadUvarint return io.ErrUnexpectedEOF when read at least 1 byte #54143
Conversation
This PR (HEAD: 0c0ac28) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/420274 to see it. Tip: You can toggle comments from me using the |
Message from Joseph Tsai: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/420274. |
This PR (HEAD: 8d56b81) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/420274 to see it. Tip: You can toggle comments from me using the |
Message from xie cui: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/420274. |
Message from Joseph Tsai: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/420274. |
This PR (HEAD: c1c2c79) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/420274 to see it. Tip: You can toggle comments from me using the |
Message from xie cui: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/420274. |
Message from xie cui: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/420274. |
Message from Joseph Tsai: Patch Set 3: Code-Review+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/420274. |
This PR (HEAD: 1e0a79b) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/420274 to see it. Tip: You can toggle comments from me using the |
Message from xie cui: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/420274. |
Message from Joseph Tsai: Patch Set 4: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/420274. |
Message from Gopher Robot: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/420274. |
Message from Keith Randall: Patch Set 4: Run-TryBot+1 Auto-Submit+1 Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/420274. |
Message from Keith Randall: Patch Set 4: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/420274. |
Message from Gopher Robot: Patch Set 4: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/420274. |
…least 1 byte Fixes #54139 Change-Id: Ifc73bd7f181b13970ee6a08968f9d8f6e55d7ff3 GitHub-Last-Rev: 1e0a79b GitHub-Pull-Request: #54143 Reviewed-on: https://go-review.googlesource.com/c/go/+/420274 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org> Run-TryBot: Keith Randall <khr@golang.org> Run-TryBot: Joseph Tsai <joetsai@digital-static.net> Auto-Submit: Keith Randall <khr@golang.org> Reviewed-by: Joseph Tsai <joetsai@digital-static.net> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Keith Randall <khr@google.com>
This PR is being closed because golang.org/cl/420274 has been merged. |
…least 1 byte Fixes golang#54139 Change-Id: Ifc73bd7f181b13970ee6a08968f9d8f6e55d7ff3 GitHub-Last-Rev: 1e0a79b GitHub-Pull-Request: golang#54143 Reviewed-on: https://go-review.googlesource.com/c/go/+/420274 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org> Run-TryBot: Keith Randall <khr@golang.org> Run-TryBot: Joseph Tsai <joetsai@digital-static.net> Auto-Submit: Keith Randall <khr@golang.org> Reviewed-by: Joseph Tsai <joetsai@digital-static.net> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Keith Randall <khr@google.com>
Fixes #54139