-
Notifications
You must be signed in to change notification settings - Fork 17.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: replace fmt.Sprintf("%d") with strconv.Itoa #59144
Conversation
This PR (HEAD: e02fde8) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/477675 to see it. Tip: You can toggle comments from me using the |
Message from Ian Lance Taylor: Patch Set 1: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/477675. |
This PR (HEAD: d41f1fa) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/477675 to see it. Tip: You can toggle comments from me using the |
Message from Philippe Antoine: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/477675. |
Message from Philippe Antoine: Patch Set 3: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/477675. |
Message from Ian Lance Taylor: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/477675. |
Message from Bryan Mills: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/477675. |
Message from Philippe Antoine: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/477675. |
Message from Cherry Mui: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/477675. |
Than fmt.Sprintf("%d",
This PR (HEAD: 1063e32) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/477675 to see it. Tip: You can toggle comments from me using the |
Message from Philippe Antoine: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/477675. |
Message from Ian Lance Taylor: Patch Set 5: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/477675. |
Message from Gopher Robot: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/477675. |
Message from Gopher Robot: Patch Set 5: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/477675. |
Message from Ian Lance Taylor: Patch Set 5: Auto-Submit+1 Code-Review+2 Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/477675. |
Message from Philippe Antoine: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/477675. |
Message from Ian Lance Taylor: Patch Set 5: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/477675. |
Message from Philippe Antoine: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/477675. |
Message from Bryan Mills: Patch Set 5: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/477675. |
This PR is being closed because golang.org/cl/477675 has been merged. |
This was found by running `git grep 'fmt.Sprintf("%d",' | grep -v test | grep -v vendor` And this was automatically fixed with gotiti https://github.com/catenacyber/gotiti and using unconvert https://github.com/mdempsky/unconvert to check if there was (tool which fixed another useless cast) Change-Id: I023926bc4aa8d51de45f712ac739a0a80145c28c GitHub-Last-Rev: 1063e32 GitHub-Pull-Request: #59144 Reviewed-on: https://go-review.googlesource.com/c/go/+/477675 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> Run-TryBot: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com>
This was found by running
git grep 'fmt.Sprintf("%d",' | grep -v test | grep -v vendor
And this was automatically fixed with gotiti https://github.com/catenacyber/gotiti
and using unconvert https://github.com/mdempsky/unconvert
to check if there was (tool which fixed another useless cast)