-
Notifications
You must be signed in to change notification settings - Fork 17.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go/internal/modget: warn -d is a no-op #66362
Conversation
This PR (HEAD: 334ccd3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/572176. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572176. |
Message from Zxilly Chou: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572176. |
Message from Michael Matloob: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572176. |
This PR (HEAD: c380648) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/572176. Important tips:
|
Message from Zxilly Chou: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/572176. |
Message from Michael Matloob: Patch Set 2: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/572176. |
Message from Michael Matloob: Patch Set 2: -Code-Review Please don’t reply on this GitHub thread. Visit golang.org/cl/572176. |
Message from Michael Matloob: Patch Set 2: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/572176. |
Message from Michael Matloob: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572176. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-20T19:02:46Z","revision":"64c4ed19d0643b653c9de2a5ff1668739c7552bf"} Please don’t reply on this GitHub thread. Visit golang.org/cl/572176. |
Message from Michael Matloob: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/572176. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results): FAILURE
Error:
Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/572176. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572176. |
Message from Michael Matloob: Patch Set 3: Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572176. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-20T19:08:37Z","revision":"e30096ecc73dc811995886e89aab3be3dbd6a3e1"} Please don’t reply on this GitHub thread. Visit golang.org/cl/572176. |
Message from Michael Matloob: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/572176. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/572176. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/572176. |
Updates #43684 Change-Id: I4aa340b1b819374159b5b6b99c14e3f70bfa1bb0 GitHub-Last-Rev: c380648 GitHub-Pull-Request: #66362 Reviewed-on: https://go-review.googlesource.com/c/go/+/572176 Reviewed-by: Michael Matloob <matloob@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Carlos Amedee <carlos@golang.org> Reviewed-by: Sam Thanawalla <samthanawalla@google.com>
This PR is being closed because golang.org/cl/572176 has been merged. |
Updates #43684