-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix awk substr invocation in libgo buildsyste #4
Conversation
The awk script used a zero-based index which worked on surprisingly many plattforms. According to the man page, however, the function expects one-based indexing. For reference see this bug in the go git repository: golang/go#45843 Signed-off-by: Christoph Höger <choeger@umpa-net.de>
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
This PR (HEAD: abe9df3) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/gofrontend/+/321169 to see it. Tip: You can toggle comments from me using the |
Message from Go Bot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/321169. |
Message from Ian Lance Taylor: Patch Set 1: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/321169. |
Message from Than McIntosh: Patch Set 1: Trust+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/321169. |
The awk script used a zero-based index which worked on surprisingly
many plattforms. According to the man page, however, the function
expects one-based indexing.
For reference see this bug in the go git repository:
golang/go#45843
Signed-off-by: Christoph Höger choeger@umpa-net.de