Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/gomobile: filter out xcrun warnings to get path #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cmd/gomobile: filter out xcrun warnings to get path #84

wants to merge 1 commit into from
+12 −2

Conversation

jakubgs
Copy link

@jakubgs jakubgs commented Sep 8, 2022

Currently some installations of Xcode and Command Line Tools cause warnings about missing extensions which break parsing of paths returned from xcrun that gomobile depends on resulting in errors like this:

cgo: C compiler "2022-09-07" not found: exec: "2022-09-07": executable file not found in $PATH

This is caused by these warnings returned on stdout by xcrun:

 > xcrun --find clang
2022-09-07 14:50:13.907 xcodebuild[69942:386823822] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionSentinelHostApplications for extension Xcode.DebuggerFoundation.AppExtensionHosts.watchOS of plug-in com.apple.dt.IDEWatchSupportCore
2022-09-07 14:50:13.908 xcodebuild[69942:386823822] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionPointIdentifierToBundleIdentifier for extension Xcode.DebuggerFoundation.AppExtensionToBundleIdentifierMap.watchOS of plug-in com.apple.dt.IDEWatchSupportCore
2022-09-07 14:50:14.041 xcodebuild[69942:386823822] XType: com.apple.fonts is not accessible.
2022-09-07 14:50:14.041 xcodebuild[69942:386823822] XType: XTFontStaticRegistry is enabled.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang

Resulting in gomobile interpreting the date 2022-09-07 as Clang compiler.

Resolves: golang/go#53316

@jakubgs
cmd/gomobile: filter out xcrun warnings to get path
f20e966 
Currently some installations of Xcode and Command Line Tools cause
warnings about missing extensions which break parsing of paths returned
from `xcrun` that `gomobile` depends on resulting in errors like this:
```
cgo: C compiler "2022-09-07" not found: exec: "2022-09-07": executable file not found in $PATH
```
This is caused by these warnings returned on `stdout` by `xcrun`:
```
 > xcrun --find clang
2022-09-07 14:50:13.907 xcodebuild[69942:386823822] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionSentinelHostApplications for extension Xcode.DebuggerFoundation.AppExtensionHosts.watchOS of plug-in com.apple.dt.IDEWatchSupportCore
2022-09-07 14:50:13.908 xcodebuild[69942:386823822] Requested but did not find extension point with identifier Xcode.IDEKit.ExtensionPointIdentifierToBundleIdentifier for extension Xcode.DebuggerFoundation.AppExtensionToBundleIdentifierMap.watchOS of plug-in com.apple.dt.IDEWatchSupportCore
2022-09-07 14:50:14.041 xcodebuild[69942:386823822] XType: com.apple.fonts is not accessible.
2022-09-07 14:50:14.041 xcodebuild[69942:386823822] XType: XTFontStaticRegistry is enabled.
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang
```
Resulting in `gomobile` interpreting the date `2022-09-07` as Clang compiler.

Resolves: golang/go#53316

Signed-off-by: Jakub Sokołowski <jakub@status.im>
@google-cla
Copy link

google-cla bot commented Sep 8, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jakubgs jakubgs mentioned this pull request Sep 8, 2022
Closed
jakubgs added a commit to status-im/status-mobile that referenced this pull request Sep 12, 2022
@jakubgs
nix: patch gomobile to sanitize xcrun output
6bd6781 
This resolves issues with weird `status-go` build errors like:
```
cgo: C compiler "2022-09-07" not found: exec: "2022-09-07": executable file not found in $PATH
```
Such errors are caused by `xcrun` spewing warnings to `stdout`. The PR
to fix this issue permanently has been created but it might take a while
before it's merged.

Fix PR: golang/mobile#84
Resolves: #13949

Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs jakubgs mentioned this pull request Sep 12, 2022
Merged
jakubgs added a commit to status-im/status-mobile that referenced this pull request Sep 12, 2022
@jakubgs
nix: patch gomobile to sanitize xcrun output
c0ff15b 
This resolves issues with weird `status-go` build errors like:
```
cgo: C compiler "2022-09-07" not found: exec: "2022-09-07": executable file not found in $PATH
```
Such errors are caused by `xcrun` spewing warnings to `stdout`. The PR
to fix this issue permanently has been created but it might take a while
before it's merged.

Fix PR: golang/mobile#84
Resolves: #13949

Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs added a commit to status-im/status-mobile that referenced this pull request Sep 12, 2022
@jakubgs
nix: patch gomobile to sanitize xcrun output
206deca 
This resolves issues with weird `status-go` build errors like:
```
cgo: C compiler "2022-09-07" not found: exec: "2022-09-07": executable file not found in $PATH
```
Such errors are caused by `xcrun` spewing warnings to `stdout`. The PR
to fix this issue permanently has been created but it might take a while
before it's merged.

Fix PR: golang/mobile#84
Resolves: #13949

Signed-off-by: Jakub Sokołowski <jakub@status.im>
ibrkhalil pushed a commit to status-im/status-mobile that referenced this pull request Sep 12, 2022
@jakubgs @ibrkhalil
nix: patch gomobile to sanitize xcrun output
a1fc5a4 
This resolves issues with weird `status-go` build errors like:
```
cgo: C compiler "2022-09-07" not found: exec: "2022-09-07": executable file not found in $PATH
```
Such errors are caused by `xcrun` spewing warnings to `stdout`. The PR
to fix this issue permanently has been created but it might take a while
before it's merged.

Fix PR: golang/mobile#84
Resolves: #13949

Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs jakubgs mentioned this pull request Sep 12, 2022
Open
@jakubgs
Copy link
Author

jakubgs commented Sep 22, 2022

I'd appreciate a review of this fix. It's causing hard to track down errors which are not deterministic and difficult to reproduce.

@gopherbot
Copy link
Contributor

This PR (HEAD: f20e966) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/432657 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/432657.
After addressing review feedback, remember to publish your drafts!

jakubgs added a commit to status-im/status-mobile that referenced this pull request Sep 22, 2022
@jakubgs
nix: patch gomobile to sanitize xcrun output
34c640d 
This resolves issues with weird `status-go` build errors like:
```
cgo: C compiler "2022-09-07" not found: exec: "2022-09-07": executable file not found in $PATH
```
Such errors are caused by `xcrun` spewing warnings to `stdout`. The PR
to fix this issue permanently has been created but it might take a while
before it's merged.

Fix PR: golang/mobile#84
Resolves: #13949

Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs
Copy link
Author

jakubgs commented Oct 10, 2022

It's been 18 days since I accepted the CLA to get this fix into this library. Any chance for a review?

@gopherbot
Copy link
Contributor

Message from Jakub Sokołowski:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/432657.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Michael Knyszek:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/432657.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/432657.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hyang-Ah Hana Kim:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/432657.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jakub Sokołowski:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/432657.
After addressing review feedback, remember to publish your drafts!

@jakubgs
Copy link
Author

jakubgs commented May 8, 2023

Hello? Anyone? It's been 8 months.

@jakubgs
Copy link
Author

jakubgs commented Jan 10, 2024

Hello?

@hajimehoshi
Copy link
Member

@hyangah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jakubgs @gopherbot @hajimehoshi