Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: Trim HTTP or HTTPS Scheme from Source Code links #5

Closed
wants to merge 1 commit into from
Closed

x/pkgsite: Trim HTTP or HTTPS Scheme from Source Code links #5

wants to merge 1 commit into from

Conversation

nickel8448
Copy link
Contributor

@nickel8448 nickel8448 commented Aug 23, 2020 •
edited
Loading

Trimming the URL by adding a new function to overview.go which trims the
URL

Modified the tests in overview_tests.go, server_tests.go accordingly.

Fixes golang/go#40943

x/pkgsite: Trim HTTP or HTTPS Scheme from Source Code links
8dc2020 
Trimming the URL by adding a new function to overview.go which trims the
URL

Fixes golang/go#40943
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Aug 23, 2020
@gopherbot
Copy link
Contributor

This PR (HEAD: 8dc2020) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/pkgsite/+/250040 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Thanabodee Charoenpiriyakij:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/250040.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Jonathan Amsterdam:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/250040.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Rahul Wadhwani:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/250040.
After addressing review feedback, remember to publish your drafts!

@nickel8448 nickel8448 closed this Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
3 participants
@nickel8448 @gopherbot @googlebot