Skip to content

Commit

Permalink
src/goToolsInformation.ts: update gopls version and unpin golangci-lint
Browse files Browse the repository at this point in the history
golangci-lint is frequently released (more frequently than vscode-go).
The community and maintainers group of golangci-lint are sufficiently
large, so we expect breakages/security issues involving the tool to be
reasonably monitored and handled. Like the alternative linter
`staticcheck`, exclude `golangci-lint` from the pinned tools list.

Updates #2763
Updates #2485

Change-Id: If4d74a56a1da8f58575ab26c0325be8a1f3906a1
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/501200
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
  • Loading branch information
hyangah committed Jun 6, 2023
1 parent 03cf976 commit df36d6f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
11 changes: 5 additions & 6 deletions src/goToolsInformation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,7 @@ export const allToolsInformation: { [key: string]: Tool } = {
modulePath: 'github.com/golangci/golangci-lint',
replacedByGopls: false,
isImportant: true,
description: 'Linter',
defaultVersion: 'v1.52.2'
description: 'Linter'
},
'revive': {
name: 'revive',
Expand All @@ -211,10 +210,10 @@ export const allToolsInformation: { [key: string]: Tool } = {
description: 'Language Server from Google',
usePrereleaseInPreviewMode: true,
minimumGoVersion: semver.coerce('1.13'),
latestVersion: semver.parse('v0.11.0'),
latestVersionTimestamp: moment('2022-12-13', 'YYYY-MM-DD'),
latestPrereleaseVersion: semver.parse('v0.12.0-pre.1'),
latestPrereleaseVersionTimestamp: moment('2023-04-24', 'YYYY-MM-DD')
latestVersion: semver.parse('v0.12.2'),
latestVersionTimestamp: moment('2023-06-01', 'YYYY-MM-DD'),
latestPrereleaseVersion: semver.parse('v0.12.2'),
latestPrereleaseVersionTimestamp: moment('2023-06-01', 'YYYY-MM-DD')
},
'dlv': {
name: 'dlv',
Expand Down
1 change: 0 additions & 1 deletion tools/allTools.ts.in
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,6 @@ export const allToolsInformation: { [key: string]: Tool } = {
replacedByGopls: false,
isImportant: true,
description: 'Linter',
defaultVersion: 'v1.52.2'
},
'revive': {
name: 'revive',
Expand Down

0 comments on commit df36d6f

Please sign in to comment.