Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the go tools to latest or export to config #2763

Closed
xiekeyi98 opened this issue May 6, 2023 · 2 comments
Closed

Bump the go tools to latest or export to config #2763

xiekeyi98 opened this issue May 6, 2023 · 2 comments
Labels
FrozenDueToAge
Milestone
v0.39.0

Comments

@xiekeyi98
Copy link

seems the go tools are hard-coded the version in https://github.com/golang/vscode-go/blob/master/src/goToolsInformation.ts#L188-L195

I was wondering if it is possible to upgrade it to the latest version. If not, have we considered doing a bump to v1.52.x?

Alternatively, have we considered exporting version selection as a configuration?
@gopherbot gopherbot added this to the Untriaged milestone May 6, 2023
@hyangah hyangah modified the milestones: Untriaged, v0.39.0 May 8, 2023
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/495261 mentions this issue: tools/allTools.ts.in: update 3rd party tools' pinned versions

@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/501200 mentions this issue: src/goToolsInformation.ts: update gopls version and unpin golangci-lint

gopherbot pushed a commit that referenced this issue Jun 6, 2023
@hyangah
src/goToolsInformation.ts: update gopls version and unpin golangci-lint
df36d6f 
golangci-lint is frequently released (more frequently than vscode-go).
The community and maintainers group of golangci-lint are sufficiently
large, so we expect breakages/security issues involving the tool to be
reasonably monitored and handled. Like the alternative linter
`staticcheck`, exclude `golangci-lint` from the pinned tools list.

Updates #2763
Updates #2485

Change-Id: If4d74a56a1da8f58575ab26c0325be8a1f3906a1
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/501200
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
@golang golang locked and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
v0.39.0
Development

No branches or pull requests
3 participants
@hyangah @xiekeyi98 @gopherbot