Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: add replay mode to launch.json #1243

Closed
icholy opened this issue Feb 21, 2021 · 4 comments
Closed

debug: add replay mode to launch.json #1243

icholy opened this issue Feb 21, 2021 · 4 comments
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Projects

Comments

@icholy
Copy link

icholy commented Feb 21, 2021

Is your feature request related to a problem? Please describe.

There is no simple way to replay an rr execution trace.

Describe the solution you'd like
I'd like to specify the path to the trace file in launch.json.

{
    "name": "Replay Trace",
    "type": "go",
    "request": "launch",
    "mode": "replay",
    "traceFile": "/home/icholy/.local/share/rr/my.test-121",
    "program": "${workspaceFolder}"
}

Describe alternatives you've considered
I have tried starting dlv replay in headless mode and connecting remotely with vscode, but it doesn't register the breakpoints.

@hyangah hyangah added this to Needs triage in Debug via automation Feb 22, 2021
@hyangah
Copy link
Contributor

hyangah commented Feb 22, 2021

There is a WIP PR #89 by @lggomez that adds the replay/coredump features to the old debug adapter. @lggomez @polinasok @suzmue is it possible to port the pr in delve dap?

@lggomez
Copy link
Contributor

lggomez commented Feb 22, 2021

@hyangah I've been completely out of the loop since the handover of the extension and the development of the new adapter so I'd be grateful if I could get a quick rundown of the new dap; I can check if the old WIP is still applicable

@polinasok polinasok added the Debug Issues related to the debugging functionality of the extension. label Feb 25, 2021
@hyangah hyangah moved this from Needs triage to Low priority in Debug Mar 1, 2021
@polinasok
Copy link
Contributor

Discussion now happening at go-delve/delve#2367

@polinasok
Copy link
Contributor

This feature is now available using the following in your launch.json

"request": "launch",
"mode": "replay",
"traceDirPath":"path/to/trace",

Thank you @lggomez for your contribution!

@icholy Please let us know if it is not working for you. Thank you.

Debug automation moved this from Low priority to Closed Sep 8, 2021
@golang golang locked and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge
Projects
No open projects
Debug
  
Closed
Development

Successfully merging a pull request may close this issue.

5 participants