package.json: add support for replay and core debug modes #1268

lggomez · 2021-03-04T04:43:05Z

New launch modes: replay and core

The following modes are added:

replay: Replays an rr trace, allowing backwards flows (reverse continue and stepback). Requires a traceDirPath property on launch.json pointing to a valid rr trace directory.
Equivalent to dlv replay <tracedir> command.
core: Replays a core dump file, showing its callstack and the file matching the callsite. Requires a coreFilePath property on launch.json pointing to a valid coredump file.
Equivalent to dlv core <exe> <corefile> command.

With the new dap service, most of the heavy work will go to delve, so this PR mainly involves getting around passing the corresponding launchArgs to delve. It´s service counterpart lies on go-delve/delve#2367

Fixes #168
Fixes #1243
Updates #110

gopherbot · 2021-03-04T04:50:28Z

This PR (HEAD: bc89abb) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/298569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-06T04:40:29Z

Message from Hyang-Ah Hana Kim:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/298569.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-03-11T03:09:35Z

This PR (HEAD: 6075579) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/298569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-11T03:18:33Z

This PR (HEAD: 9520700) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/298569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-03-22T02:20:28Z

This PR (HEAD: 3ea3d73) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/298569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-04-01T22:47:42Z

This PR (HEAD: 0d57463) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/298569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-04-05T16:43:04Z

This PR (HEAD: c0af810) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/298569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-04-05T16:47:06Z

This PR (HEAD: edf0858) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/298569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-04-06T21:23:07Z

This PR (HEAD: 366fa88) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/298569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-04-30T01:45:35Z

This PR (HEAD: 3c2f52e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/298569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-05-06T00:13:01Z

This PR (HEAD: 9134201) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/298569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-05-20T03:00:46Z

This PR (HEAD: ec0b234) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/298569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-05-22T23:43:43Z

This PR (HEAD: d85f75a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/298569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-06-20T01:49:43Z

This PR (HEAD: 2a608ca) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/298569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-08-10T02:33:18Z

This PR (HEAD: 39e88b2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/298569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-08-10T16:51:38Z

Message from Hyang-Ah Hana Kim:

Patch Set 27: Run-TryBot+1 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/298569.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-10T16:59:23Z

Message from kokoro:

Patch Set 27:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/091f1fa0-41cb-46fa-a04d-31be3b8c0411

Please don’t reply on this GitHub thread. Visit golang.org/cl/298569.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-10T17:02:04Z

Message from kokoro:

Patch Set 27: TryBot-Result+1

Kokoro presubmit build finished with status: SUCCESS
Logs at: https://source.cloud.google.com/results/invocations/091f1fa0-41cb-46fa-a04d-31be3b8c0411

Please don’t reply on this GitHub thread. Visit golang.org/cl/298569.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-10T17:15:11Z

Message from Hyang-Ah Hana Kim:

Patch Set 28: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/298569.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-10T17:15:12Z

Message from Hyang-Ah Hana Kim:

Patch Set 28: Code-Review+2 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/298569.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-10T17:23:33Z

Message from Suzy Mueller:

Patch Set 29: Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/298569.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-10T17:59:26Z

Message from Hyang-Ah Hana Kim:

Patch Set 30: Published edit on patch set 29.

Please don’t reply on this GitHub thread. Visit golang.org/cl/298569.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-10T17:59:28Z

Message from Hyang-Ah Hana Kim:

Patch Set 30: Run-TryBot+1 Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/298569.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-10T18:44:29Z

This PR (HEAD: e055352) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/298569 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-08-10T18:49:52Z

Message from Hyang-Ah Hana Kim:

Patch Set 31: Run-TryBot+1 Code-Review+2 Trust+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/298569.
After addressing review feedback, remember to publish your drafts!

## New launch modes: replay and core The following modes are added: - **replay**: Replays an rr trace, allowing backwards flows (reverse continue and stepback). Requires a `traceDirPath` property on `launch.json` pointing to a valid rr trace directory. Equivalent to `dlv replay <tracedir>` command. - **core**: Replays a core dump file, showing its callstack and the file matching the callsite. Requires a `coreFilePath` property on `launch.json` pointing to a valid coredump file. Equivalent to `dlv core <exe> <corefile>` command. With the new dap service, most of the heavy work will go to delve, so this PR mainly involves getting around passing the corresponding launchArgs to delve. It´s service counterpart lies on go-delve/delve#2367 Change-Id: Idc21f27152387c07c844fa471b89d95f38c2545b GitHub-Last-Rev: e055352 GitHub-Pull-Request: #1268 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/298569 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Trust: Hyang-Ah Hana Kim <hyangah@gmail.com> Trust: Suzy Mueller <suzmue@golang.org>

gopherbot · 2021-08-10T18:55:21Z

Message from kokoro:

Patch Set 31:

Kokoro presubmit build starting for golang/vscode-go/gcp_ubuntu/presubmit
Logs at:
https://source.cloud.google.com/results/invocations/0ce723b1-6dc5-48f8-aac6-30a17d8629a6

Please don’t reply on this GitHub thread. Visit golang.org/cl/298569.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-08-10T18:57:55Z

This PR is being closed because golang.org/cl/298569 has been merged.

The following modes are added: - **replay**: Replays an rr trace, allowing backwards flows (reverse continue and stepback). Requires a `traceDirPath` property on `launch.json` pointing to a valid rr trace directory. Equivalent to `dlv replay <tracedir>` command. - **core**: Replays a core dump file, showing its callstack and the file matching the callsite. Requires a `coreFilePath` property on `launch.json` pointing to a valid coredump file. Equivalent to `dlv core <exe> <corefile>` command. With the new dap service, most of the heavy work will go to delve, so this PR mainly involves getting around passing the corresponding launchArgs to delve. It´s service counterpart lies on go-delve/delve#2367 GitHub-Last-Rev: e055352 GitHub-Pull-Request: #1268 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/298569 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Trust: Hyang-Ah Hana Kim <hyangah@gmail.com> Trust: Suzy Mueller <suzmue@golang.org> Change-Id: I7b6b3b7b9d7c30d552a4401892492c74ec2e3023 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/346092 Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> Reviewed-by: Suzy Mueller <suzmue@golang.org> TryBot-Result: kokoro <noreply+kokoro@google.com>

google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Mar 4, 2021

lggomez mentioned this pull request Mar 7, 2021

service/dap: Support for replay and core modes go-delve/delve#2367

Merged

lggomez force-pushed the dap.rr-support branch from bc89abb to 6075579 Compare March 11, 2021 03:07

lggomez force-pushed the dap.rr-support branch from 6ddf3b0 to 3ea3d73 Compare March 22, 2021 02:19

lggomez force-pushed the dap.rr-support branch from b89ff39 to 0d57463 Compare April 1, 2021 22:46

lggomez force-pushed the dap.rr-support branch from c0af810 to edf0858 Compare April 5, 2021 16:45

lggomez force-pushed the dap.rr-support branch from cbc1576 to 366fa88 Compare April 6, 2021 21:14

lggomez force-pushed the dap.rr-support branch from 366fa88 to 3c2f52e Compare April 30, 2021 01:45

Merge remote-tracking branch 'upstream/master'

0c11c64

lggomez force-pushed the dap.rr-support branch from 9134201 to ec0b234 Compare May 20, 2021 02:58

Merge remote-tracking branch 'upstream/master'

7de25b0

lggomez force-pushed the dap.rr-support branch from ec0b234 to d85f75a Compare May 22, 2021 23:40

This was referenced May 22, 2021

Add delve rewind/replay and core dump support #1507

Closed

src/debugAdapter/goDebug.ts: Add support for delve replay, rewind and core dumps #88 #89

Closed

Merge remote-tracking branch 'upstream/master'

54a3d8e

lggomez force-pushed the dap.rr-support branch from d85f75a to 2a608ca Compare June 20, 2021 01:47

lggomez added 8 commits August 9, 2021 23:30

Remove from backend list

4725310

Update traceDirectory description

c1802ca

Update traceDirectory description

d60f674

Reintroduce coredump mode as core

28a35ef

Remove record mode

1a440c2

Update replay and core mode parameters

f515c40

dap: Do not parse program on modes that do not require it

f9b0f0e

Revert package-lock change

26ecf7b

lggomez force-pushed the dap.rr-support branch from 5ba1a17 to 26ecf7b Compare August 10, 2021 02:32

hyangah added this to the v0.27.1 milestone Aug 10, 2021

lggomez added 2 commits August 10, 2021 15:42

Update debug documentation

8b597cd

Revert package version change

e055352

lggomez force-pushed the dap.rr-support branch from 39e88b2 to e055352 Compare August 10, 2021 18:44

hyangah changed the title ~~Support for replay and core modes~~ package.json: add support for replay and core debug modes Aug 10, 2021

gopherbot closed this Aug 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

package.json: add support for replay and core debug modes #1268

package.json: add support for replay and core debug modes #1268

lggomez commented Mar 4, 2021 •

edited by polinasok

gopherbot commented Mar 4, 2021

gopherbot commented Mar 6, 2021

gopherbot commented Mar 11, 2021

gopherbot commented Mar 11, 2021

gopherbot commented Mar 22, 2021

gopherbot commented Apr 1, 2021

gopherbot commented Apr 5, 2021

gopherbot commented Apr 5, 2021

gopherbot commented Apr 6, 2021

gopherbot commented Apr 30, 2021

gopherbot commented May 6, 2021

gopherbot commented May 20, 2021

gopherbot commented May 22, 2021

gopherbot commented Jun 20, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

package.json: add support for replay and core debug modes #1268

package.json: add support for replay and core debug modes #1268

Conversation

lggomez commented Mar 4, 2021 • edited by polinasok

New launch modes: replay and core

gopherbot commented Mar 4, 2021

gopherbot commented Mar 6, 2021

gopherbot commented Mar 11, 2021

gopherbot commented Mar 11, 2021

gopherbot commented Mar 22, 2021

gopherbot commented Apr 1, 2021

gopherbot commented Apr 5, 2021

gopherbot commented Apr 5, 2021

gopherbot commented Apr 6, 2021

gopherbot commented Apr 30, 2021

gopherbot commented May 6, 2021

gopherbot commented May 20, 2021

gopherbot commented May 22, 2021

gopherbot commented Jun 20, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

gopherbot commented Aug 10, 2021

lggomez commented Mar 4, 2021 •

edited by polinasok