Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/debugAdapter/goDebug.ts: Add support for delve replay, rewind and core dumps #88 #89

Closed
wants to merge 1 commit into from

Conversation

lggomez
Copy link
Contributor

@lggomez lggomez commented May 24, 2020

Fixes microsoft#1529 and microsoft#3169

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label May 24, 2020
@lggomez
Copy link
Contributor Author

lggomez commented May 24, 2020

As commented on the original PR:

There are still 2 main points to polish here:

  • Disable or make the non-compatible actions (continue, steps, pause) no-ops on core mode, since they're not supported by delve and will trigger an error
  • Improve the handling of trace records from optimized binaries (I don't know yet if we can infer this in some way to warn the user, or just ignore the errors with a warning describing this scenario)

For reference, all previous discussion can be seen on the original PR here: microsoft#2414

@gopherbot
Copy link
Collaborator

This PR (HEAD: 921ee66) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/vscode-go/+/235119 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Collaborator

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/235119.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Collaborator

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/235119.
After addressing review feedback, remember to publish your drafts!

@lggomez
Copy link
Contributor Author

lggomez commented May 22, 2021

As this PR is (very) stale and it currently is on the way of being deprecated by the implementation being done at dlv-dap (see #1268 and its description) I may close this PR to favor the later implementation unless anyone opposes in the following days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants