-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add toggle for deemphasized code #1916
Comments
@suzmue @polinasok |
@ansiwen Thanks for the feedback. After seeing this feature in use for a while, I think we should consider removing the source presentation hint all together. It would still be possible to provide a visual indication of runtime vs source stack frames, without deemphasizing the source. This is what it currently looks like ( If we move the presentation hint 'subtle' to the stack frame instead of the source, we can instead have the following ( Or of course we could remove the presentation hints all together, or just put this behind a configurable option. |
I think using Is there such thing as too many configurable launch options? It is does seem more intuitive for the user if these things were evaluated on the fly dynamically - i.e. sticky expansions. It would have been good to combine hiding system frames and goroutines into one option. Too late now? We have released it already, haven't we? |
We had a discussion offline and all are in agreement that we don't need to collapsing can be removed in favor of |
@ansiwen go-delve/delve#2810 was merged and available from the head. Please update |
Is your feature request related to a problem? Please describe.
Since go-delve/delve#2522 stack frames in runtime have the "deemphasize" presentation hint. This results in vscode to always jump out of the runtime stack frames while stepping through runtime code. Especially when debugging runtime changes this is not usable and requires to switch back to the legacy debug adapter.
Describe the solution you'd like
There needs to be a possibility to ignore the presentation hint globally, or to toggle it per debugging session/frame by right clicking on the stack frame and toggle it similar to Toggle skipping this file. Alternatively, similar to these skipping rules, setting a breakpoint in runtime code could/should disable the deemphasizing.
The text was updated successfully, but these errors were encountered: