Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Govulncheck integration test is broken with gopls v0.16.0 #3427

Closed
hyangah opened this issue Jun 20, 2024 · 1 comment
Closed

Govulncheck integration test is broken with gopls v0.16.0 #3427

hyangah opened this issue Jun 20, 2024 · 1 comment
Assignees
@hyangah
Milestone
v0.42.0

Comments

@hyangah
Copy link
Contributor

hyangah commented Jun 20, 2024

The vscode integration test had been used "Share feedback at https://go.dev/s/govulncheck-feedback." as the signal for the end of govulncheck text output display. gopls v0.16.0 uses x/vuln v1.0.4 and it looks like x/vuln doesn't spit out the info any more.
Stop depending on it.

Easiest is to pick different patterns, but that's still hacky and can break any time.
Better approach is to check the progress report end message.
@gopherbot gopherbot added this to the Untriaged milestone Jun 20, 2024
@adonovan adonovan modified the milestones: Untriaged, v0.42.0 Jun 20, 2024
@hyangah
Copy link
Contributor Author

hyangah commented Jun 27, 2024

Fixed.

@hyangah hyangah closed this as completed Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyangah hyangah

Labels
None yet
Projects
None yet
Milestone
v0.42.0
Development

No branches or pull requests
3 participants
@hyangah @adonovan @gopherbot