Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Like削除のパラメータ変更 #93

Open
gold-kou opened this issue Dec 5, 2021 · 1 comment
Open

[Backend] Like削除のパラメータ変更 #93

gold-kou opened this issue Dec 5, 2021 · 1 comment
Assignees

Comments

@gold-kou
Copy link
Owner

gold-kou commented Dec 5, 2021

DELETE /likes/{posting_id} になってるけど、パラメータはlike_idが正しそう。

@gold-kou gold-kou self-assigned this Dec 5, 2021
@gold-kou gold-kou added bug Something isn't working refactor and removed bug Something isn't working labels Dec 5, 2021
@gold-kou
Copy link
Owner Author

たしかにlike_idをリクエストパラメータにしたほうが綺麗そう。

GET /postings でlike_idをレスポンスパラメータに追加すればできそう。ただし、liked=trueの時だけ入る値なのでrequiredでない?そのときフロントで参照できなくてエラーになるかも?ならば、requiredにしてliked=falseのときは0にする?

いずれにせよ、今の仕様でも問題なく動作するため、対応の優先度は低い。

@gold-kou gold-kou added the low label Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant