Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: A UI for creating pranks and viewing activity/resiliency #2

Open
goldbergyoni opened this issue Jul 8, 2018 · 13 comments
Labels
enhancement New feature or request

Comments

@goldbergyoni
Copy link
Owner

@KromDaniel Sharing a thought - including a UI for quick pranks creation and viewing results can appeal to many. What do you think?

pranks_log2
new_prank

@goldbergyoni goldbergyoni added the enhancement New feature or request label Jul 8, 2018
@sebmaz93
Copy link
Collaborator

image

@amaliaman @i0natan just small part if you like the layout.

@goldbergyoni
Copy link
Owner Author

@TITAN9389 I think it looks great! But I'll let @amaliaman comment - she has much better eye for UX matters... :]

I would just ask if it's possible to include the monkey some place near/within the header

Does the API work fine for you?

@sebmaz93
Copy link
Collaborator

@i0natan didn't try the API yet, will try it today and see , for the monkey its the same logo on the main repo page ?

@goldbergyoni
Copy link
Owner Author

@TITAN9389 Yes, same monkey. You'll probably have to shrink it

@sebmaz93
Copy link
Collaborator

@i0natan it looks small if include it in header , is it okay ?
image

@goldbergyoni
Copy link
Owner Author

@amaliaman what do you think?

@amaliaman
Copy link
Collaborator

Hi, sorry for the delay (kids...)
I think that in the icon should be simpler so it would look coherent in small sizes.
The pranks log looks good!

@sebmaz93
Copy link
Collaborator

@i0natan @amaliaman I've Pushed and Open pull request .if you can merge and check the UI View 2 Finished + responsiveness ( ps. i have some Q tried to connect via skype but non were online.)
image

@goldbergyoni
Copy link
Owner Author

@TITAN9389 Looks very nice, looking forward to try it. I will be able to be online in Skype in 2-3 hour ,check the UI and bounce with feedback later tonight.

Can you block few hours on Monday or Tuesday for small enhancements?

@sebmaz93
Copy link
Collaborator

@i0natan okay , yes on Tuesday i guess.

@sebmaz93
Copy link
Collaborator

@i0natan @amaliaman I've added MobX with Decorators without ejecting CRA , its working fine check it plus i've made some automated npm script so you just need to run npm run start:app and it will install UI dependencies & build it then serve it on localhost:8081.

@goldbergyoni
Copy link
Owner Author

@TITAN9389 You rock!

Also including the create prank logic?

@sebmaz93
Copy link
Collaborator

@i0natan yes everything included(GET,POST,WS). (just UI enhancements left).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants