Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower engines requirement to support node 4? #54

Closed
jeffposnick opened this issue Mar 8, 2017 · 5 comments
Closed

Lower engines requirement to support node 4? #54

jeffposnick opened this issue Mar 8, 2017 · 5 comments

Comments

@jeffposnick
Copy link

The underlying sw-precache library has an engines requirement of node 4+. I noticed that your library requires node 5+ (see facebook/create-react-app#1728 (comment)).

Are you using anything specific to node 5 that won't work in node 4? If no, could you lower the engines requirement to support node 4 as well?
@jeffposnick jeffposnick mentioned this issue Mar 8, 2017
Merged
@wtgtybhertgeghgtwtg
Copy link

wtgtybhertgeghgtwtg commented Mar 8, 2017 •
edited
Loading

index.js makes use of the spread operator, which isn't available until node@5. Scratch that, it goes through babel.

@goldhand
Copy link
Owner

I don't think there is. I will change that asap. Sorry for being MIA on the other review requests @jeffposnick. I've been swamped at my day job

@goldhand
Copy link
Owner

Updated this in 0.9.1 Should be ready for facebook/create-react-app#1728

@jeffposnick
Copy link
Author

You're a hero for maintaining this repo, @goldhand!

@goldhand
Copy link
Owner

Aw, thanks! Its not much work and I enjoy doing it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeffposnick @goldhand @wtgtybhertgeghgtwtg