Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO artifacts #32

Closed
Krigpl opened this issue Apr 6, 2018 · 1 comment
Closed

TODO artifacts #32

Krigpl opened this issue Apr 6, 2018 · 1 comment

Comments

@Krigpl
Copy link
Contributor

Krigpl commented Apr 6, 2018

Clean this up:

contracts
modernize contract’s language style
replace “always ticking” timelock with “withdrawal delay” mechanism
limit oracle’s power to amounts declared by parties
consider createChannel to be dependent on arguments

and not on hidden variable id; one channel per (owner, receiver) pair
rework GNTW to be ERC223 compliant
and merge channel creation with channel funding in single transaction
reconsider names of some of events
golem node id registration in the deposit
create a script that deploys contracts on Rinkeby
create and deploy a faucet contract
should it do the crowdfunding?
on deposits security
timeout nie jest konieczny bo oracle nie widzi wszystkich spraw
counter-argument: other guys can attempt to reuse those to replay
jezeli “dochody” oracla sa w cold wallet, to nie mozna zarobic hackując oracla
jeżeli poszkodowany nie może zarobić na byciu poszkodowanym, to niema powodu atakować oracla
palenie części tokenów winnego jest lepsze od redystrybucji tych tokenów ponieważ

powoduje to że bycie ofiarą nie jest dochodowe

@Krigpl
Copy link
Contributor Author

Krigpl commented Jun 11, 2018

This is pretty much done.

@Krigpl Krigpl closed this as completed Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant