-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: allow setting message properties in AMQPConnection #270
Comments
I'm not sure about correlation and reply-to as both of those are specfically managed by the library in order to make RPC work properly using RabbitMQs direct-reply-to functionality but there are definitely some useful ones that people might want to leverage that should be exposed |
Yea I think mainly for us what's missing is the
Setting |
@RoniLeshes I'll implement this options but a warning about some other properties such as the correlationId because they can interfere with, a warning would be dispatched in the console if the correlationId is overwritten |
I think we should just start with expiration and not allow them to override correlationId until we have a clearer understanding of the use case |
As seen in the README, the way to send RPC is doing something like so:
RabbitMQ messages are capable of setting per-message properties.
Beside the basic properties, some optional properties are available, like correlation id, reply-to, etc... https://www.rabbitmq.com/publishers.html#message-properties
Currently there is no way of setting such properties using
AMQPConnection
.It seems that the implementation using
amqplib
should be fairly easy:https://github.com/squaremo/amqp.node/blob/main/lib/api_args.js#L223
Unfortunately I don't have the time to do so right now, maybe I'll open a PR in a week or two from now, if no one else picked it up
The text was updated successfully, but these errors were encountered: